Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automated build trigger and validation of RPMs/Debs #631

Open
tpepper opened this issue Sep 19, 2018 · 31 comments
Open

automated build trigger and validation of RPMs/Debs #631

tpepper opened this issue Sep 19, 2018 · 31 comments
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Milestone

Comments

@tpepper
Copy link
Member

tpepper commented Sep 19, 2018

Today we have a release step of pinging @mbohlool or @jpbetz on Slack indicating that RPMs/Debs need built for a particular "1.X.y-{beta|rc}". This needs automated. Similarly once, built folks have manually discovered build issues, since the artifacts don't have pre-publication automated validation. This all needs automated to tighten up and improve the build process. Ideally we'd turn the full release crank for all of alpha/beta/rc and final releases in order to always know the process is healthy.

@dims
Copy link
Member

dims commented Sep 19, 2018

Also see kubernetes/sig-release#302

@liztio
Copy link

liztio commented Sep 19, 2018

As a kubeadm maintainer, this would make my job of validating releases much easier.

@calebamiles
Copy link
Contributor

@liztio you can use the bazel tooling to generate debs and rpms locally today. What are the gaps between the spec files there and the ones here?

cc: @timothysc

@liztio
Copy link

liztio commented Sep 19, 2018

I can, but it's time consuming and slow. I have to use a separate machine because bazel doesn't support cross compilation from OSX yet. Plus we've had discrepancies in the bazel / shell release process debs before.

@ixdy
Copy link
Member

ixdy commented Sep 19, 2018

The specs in kubernetes/release/debian and kubernetes/kubernetes/build/debs have drifted a bit, and someone should probably unify them again. I'm not sure exactly how they differ.

Also, the "official" debs (using kubernetes/release/debian) use the outputs from the non-bazel builds, which may be different. (One notable issue is that the bazel-built debs only support linux/amd64.)

@liztio
Copy link

liztio commented Sep 19, 2018

I just built packages for kubeadm and kubelet on the v1.12.0-rc.1 branch, but the deb files and binaries came out labelled as v1.13.0-alpha.0.1342+cdadc117e1ea8d. Maybe there's some way to override this, but it's definitely not as simple as bazel build //build/debs:kubeadm

this was my mistake, ignore me!

@ixdy
Copy link
Member

ixdy commented Sep 19, 2018

@liztio did you build at HEAD rather than at the v1.12.0-rc.1 tag? Bazel (and make) basically uses git describe --tags to produce the version string, so it'll only use v1.12.0-rc.1 if you have checked out that tag explicitly.

@timothysc
Copy link
Member

timothysc commented Sep 19, 2018

@ixdy I get the same results when building from that tag, but I also use make not bazel.

Also I consider it onerous to force everyone to rebuild from tag. Ideally we'd like to get real beta-testers in the wild.

@liztio
Copy link

liztio commented Sep 19, 2018

@ixdy ah my bad. I didn't re-checkout when I moved from my local machine to a remote linux box. Ignore me!

@ixdy
Copy link
Member

ixdy commented Sep 19, 2018

@timothysc to be clear, I do agree with you. we really do need to integrate rpm/deb building with the release process.

@tpepper
Copy link
Member Author

tpepper commented Sep 20, 2018

Also -beta and -rc debs/rpms ought to go into a different repo than the official release ones.

@dims
Copy link
Member

dims commented Sep 22, 2018

note from @calebamiles

./jenkins.sh --kube-version 1.12.0 --distros xenial` (debs)
./docker-build.sh` (rpms)

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 21, 2018
@nikhita
Copy link
Member

nikhita commented Dec 24, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 24, 2019
@dims
Copy link
Member

dims commented Apr 16, 2019

@tpepper still valid?

@justaugustus
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2019
@justaugustus
Copy link
Member

/help
/milestone v1.15
/priority important-soon
/area release-eng

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/release-eng Issues or PRs related to the Release Engineering subproject labels May 1, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 1, 2019
@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 1, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 29, 2019
@listx
Copy link

listx commented Sep 23, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 23, 2019
@listx
Copy link

listx commented Sep 23, 2019

/milestone v1.17

@k8s-ci-robot
Copy link
Contributor

@listx: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Dec 9, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 8, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 7, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member

/remove-lifecycle rotten
/lifecycle frozen
/milestone v1.22
/assign
/unassign @tpepper
/reopen

Part of kubernetes/sig-release#1372.

@k8s-ci-robot k8s-ci-robot assigned justaugustus and unassigned tpepper Jan 20, 2021
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.15, v1.22 Jan 20, 2021
@k8s-ci-robot k8s-ci-robot reopened this Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/lifecycle frozen
/milestone v1.22
/assign
/unassign @tpepper
/reopen

Part of kubernetes/sig-release#1372.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 20, 2021
@justaugustus justaugustus removed their assignment Dec 5, 2021
@justaugustus justaugustus added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests