Krel is unreliable on Windows

[katcosgrove]

What happened:

From multiple Release Retros, we've found that Krel is largely unreliable on Windows, even when using WSL. Most recently, it has failed to clone the repo into the temp directory regardless of flags set. Context: https://kubernetes.slack.com/archives/CN1KH4K9A/p1731345719535379

What you expected to happen:

Clone the repo into the temp directory for generation of release notes.

How to reproduce it (as minimally and precisely as possible):

Attempt to follow normal instructions for generating release notes on Windows using WSL.

Anything else we need to know?:

Environment:

• Cloud provider or hardware configuration: Unknown
• OS (e.g: cat /etc/os-release): WSL2 on Windows
• Kernel (e.g. uname -a):
• Others:

[TatianaSelezneva]

I'm wondering if I can have a look and get assigned to the issue? :)

[TatianaSelezneva]

/assign @TatianaSelezneva

[TatianaSelezneva]

In the referenced slack conversation krel is running directly on Windows and error is 'repository not found'

In the downstream dependency sigs.k8s.io/release-sdk/git while constructing git repo URL we used OS specific way of concatenating part of the URL.

slug := filepath.Join(org, repo) -> problem, we want something like slug := org + "/" + repo

// returns a repo URL for the specified repo.
// Expected result is one of the following:
// - https://github.com/<org>/<repo>
// - git@github.com:<org>/<repo>.
func GetRepoURL(org, repo string, useSSH bool) (repoURL string) {
	slug := filepath.Join(org, repo) -> problem, we want something like slug := org + "/" + repo
	if useSSH {
		repoURL = fmt.Sprintf("%s%s", defaultGithubAuthRoot, slug)
	} else {
		repoURL = (&url.URL{
			Scheme: "https",
			Host:   "github.com",
			Path:   slug,
		}).String()
	}

	return repoURL
}

As a result we were getting backslash in the URL (https://github.com/kubernetes\kubernetes), which can lead to errors.

When I ran tests in the Windows environment, a few tests has failed due to backslash in the URL. With this fix tests are passing.

kubernetes-sigs/release-sdk#482

CC @katcosgrove

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale