Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotate calebamiles for mrbobbytables in github admin team #900

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Rotate calebamiles for mrbobbytables in github admin team #900

merged 2 commits into from
Jun 12, 2019

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jun 10, 2019

Changes are in three categories:

  • OWNERS: reviewer -> approver
  • org.yaml: member -> admin
  • teams.yaml: member -> maintainer

We'd rather there be no team maintainers, but GitHub requires that
people with Owner permission be listed as maintainers.

/hold
waiting for steering lgtms on kubernetes/community#3787

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2019
@spiffxp spiffxp mentioned this pull request Jun 10, 2019
Merged
@spiffxp spiffxp force-pushed the add-mrbobbytables-as-owner branch from 7c00f96 to 094da19 Compare June 10, 2019 21:54
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/pm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2019
@cblecker
Copy link
Member

Need to edit this list too, or things will fail:

org/admin/BUILD.bazel

Lines 14 to 19 in 4d75ebf

"--required-admins=calebamiles",
"--required-admins=cblecker",
"--required-admins=fejta",
"--required-admins=idvoretskyi",
"--required-admins=nikhita",
"--required-admins=spiffxp",

@cblecker
Copy link
Member

oh, also the root OWNERS

@spiffxp spiffxp force-pushed the add-mrbobbytables-as-owner branch from 094da19 to 69e0514 Compare June 10, 2019 22:49
@justaugustus
Copy link
Member

Congrats @mrbobbytables!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2019
@cblecker
Copy link
Member

/lgtm
/approve

Leaving hold in place as we still need steering approval.

@mrbobbytables
Copy link
Member

Little early, but thank you <3

@spiffxp
Include org in error message about admin/member dupe
8ba1435
@spiffxp
Rotate calebamiles for mrbobbytables in github admin team
1014314 
Changes are in three categories:
- OWNERS: reviewer -> approver
- org.yaml: member -> admin
- teams.yaml: member -> maintainer

We'd rather there be no team maintainers, but GitHub requires that
people with Owner permission be listed as maintainers.
@spiffxp spiffxp force-pushed the add-mrbobbytables-as-owner branch from 69e0514 to 1014314 Compare June 12, 2019 20:46
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Jun 12, 2019

/hold cancel
kubernetes/community#3787 has merged

rebased

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2019
cblecker
cblecker approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
:shipit:

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 84e67c6 into kubernetes:master Jun 12, 2019
@nikhita
Copy link
Member

nikhita commented Jun 13, 2019

🎉 🎉 🎉

@spiffxp spiffxp deleted the add-mrbobbytables-as-owner branch July 26, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@justaugustus justaugustus

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spiffxp @cblecker @justaugustus @mrbobbytables @k8s-ci-robot @nikhita