Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service catalog teams #865

Merged
merged 2 commits into from
May 31, 2019
Merged

Update service catalog teams #865

merged 2 commits into from
May 31, 2019

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented May 30, 2019 •
edited
Loading

fixes #844.
cc: @jberkhahn

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 30, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. labels May 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2019
@jberkhahn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@jberkhahn
Copy link
Contributor

Ah, looks like I need to apply for kubernetes-sig membership.

As for Jay and Kibbles, neither of them are still actively contributing to the project, so they could be removed from the lists. I'm not sure what standard procedure for that is, though.

@cblecker
Copy link
Member Author 

config_test.go:250: The following members of team service-catalog-maintainers are not Kubernetes SIGs org members: arschles, duglin, eriknelson, jberkhahn, jboyd01, jpeeler, kibbles-n-bytes, luksa, martinmaly, mhbauer, n3wscott, nilebox, slack, staebler, vaikas-google
config_test.go:250: The following members of team service-catalog-admins are not Kubernetes SIGs org members: jberkhahn, jboyd01
config_test.go:250: The following members of team sig-service-catalog are not Kubernetes org members: jboyd01, kibbles-n-bytes

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@cblecker
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2019
@jberkhahn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@cblecker
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2019
@cblecker cblecker mentioned this pull request May 30, 2019
Closed
@k8s-ci-robot k8s-ci-robot merged commit 50959e5 into kubernetes:master May 31, 2019
@cblecker cblecker deleted the service-catalog branch May 31, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberkhahn jberkhahn Awaiting requested review from jberkhahn

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@jberkhahn jberkhahn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REQUEST: clean up SIG Service Catalog teams
3 participants
@cblecker @k8s-ci-robot @jberkhahn