Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning description of the teams #853

Merged
merged 1 commit into from
May 30, 2019
Merged

Cleaning description of the teams #853

merged 1 commit into from
May 30, 2019

Conversation

ezzoueidi
Copy link
Contributor

Fixes #850

/assign @cblecker

@k8s-ci-robot
Copy link
Contributor

Welcome @nzoueidi!

It looks like this is your first PR to kubernetes/org 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/org has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 29, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @nzoueidi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 29, 2019
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 29, 2019
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 29, 2019
@justaugustus
Copy link
Member

@nzoueidi -- can you rebase this?

@nikhita
Copy link
Member

nikhita commented May 30, 2019 •
edited
Loading

We can also get rid of these teams. The second team doesn't even have any members. 🙃

org/config/kubernetes-incubator/org.yaml

Lines 381 to 388 in a296b35

incubator-admin:
description: ""
members:
- philips
privacy: closed
incubator-admins:
description: ""
privacy: closed

@ezzoueidi
Copy link
Contributor Author

ezzoueidi commented May 30, 2019 •
edited
Loading

@nzoueidi -- can you rebase this?

Yep, I will do it right now. I am trying to resolve the merge conflict I did :').

@nikhita should we remove both teams or we keep the first one? If we want to keep the first team we need also to rename it to admins-incubator

@nikhita
Copy link
Member

nikhita commented May 30, 2019

@nikhita should we remove both teams or we keep the first one?

I think we can remove both teams because they don't really have any purpose. Only the github admin team has admin access to the incubator org so incubator-admin isn't really useful. :)

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2019
@nikhita
Copy link
Member

nikhita commented May 30, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 30, 2019
@ezzoueidi
Cleaning description of the teams
107d38e 
This commit contains some more changes:

* Remove all *-reviewers teams.
* Remove teams that are associated with archived repos.
* Remove incubator-admins teams so they are no longer used.
* Fix maintainers of the kubernetes blog
rlenferink
rlenferink approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@rlenferink rlenferink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for helping out @nzoueidi !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@cblecker
Copy link
Member

/lgtm
/approve

@nzoueidi Thank you so much for this! This was really helpful cleanup. 🚀

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, nzoueidi, rlenferink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit 46182e1 into kubernetes:master May 30, 2019
@ezzoueidi ezzoueidi mentioned this pull request Jun 6, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker left review comments

@rlenferink rlenferink rlenferink approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@cblecker cblecker

@rlenferink rlenferink

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tidy up some teams
6 participants
@ezzoueidi @k8s-ci-robot @justaugustus @nikhita @cblecker @rlenferink