Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unneeded teams #797

Merged
merged 3 commits into from
May 9, 2019
Merged

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented May 7, 2019

  • Remove @kubernetes/examples-reviewers: it contains one person, that person is already a maintainer, and it doesn't provide any permissions.
  • Remove @kubernetes/kubernetes-reviewers: team provides no additional access, and isn't useful for mentioning.
  • Remove @kubernetes/kubernetes-admins: All members of this group still have write access via kubernetes-maintainers, and admin access shouldn't be needed -- releases are cut by kubernetes-release-managers.

/cc @kubernetes/owners
/hold

@k8s-ci-robot k8s-ci-robot requested a review from a team May 7, 2019 05:15
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 7, 2019
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@justaugustus
Copy link
Member

/lgtm
/approve

Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, idvoretskyi, justaugustus, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member

spiffxp commented May 7, 2019

/lgtm

@idvoretskyi
Copy link
Member

@cblecker anything that blocks us from merging?

@cblecker
Copy link
Member Author

cblecker commented May 9, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit df9e3bb into kubernetes:master May 9, 2019
@cblecker cblecker deleted the team-changes branch May 9, 2019 17:22
@lavalamp
Copy link
Member

lavalamp commented May 9, 2019

This locked me out of merging to the rate-limiting feature branch.

@cblecker
Copy link
Member Author

cblecker commented May 9, 2019

@lavalamp Do tests not pass on that branch?

@lavalamp
Copy link
Member

lavalamp commented May 9, 2019

They pass at the moment. The issue is kubernetes/test-infra#12303 effectively prevents merging master back into the branch.

@cblecker
Copy link
Member Author

cblecker commented May 9, 2019

Ohhhh, okay I get it. Working on solution..

@lavalamp
Copy link
Member

lavalamp commented May 9, 2019

The solution we have at the moment is kubernetes/kubernetes#77652 but that prevents merging the feature branch back into master...

Also, I think there's no way now to create feature branches?

@lavalamp
Copy link
Member

lavalamp commented May 9, 2019

(previously I just did that)

@cblecker
Copy link
Member Author

cblecker commented May 9, 2019

@lavalamp I just opened #804 to create a group to delegate this permission to you. We should figure out better solutions to these, but I don't want to block active work.

@lavalamp
Copy link
Member

lavalamp commented May 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants