Add sig-docs-hi members #748

mittalyashu · 2019-04-20T08:48:15Z

Add owners and reviewers for the Hindi team.

Refs

k8s-ci-robot · 2019-04-20T08:48:23Z

Hi @mittalyashu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nikhita · 2019-04-20T09:01:26Z

/hold

OWNERS need to be added in the website repo first.

nikhita · 2019-04-20T09:04:38Z

config/kubernetes/sig-docs/teams.yaml

@@ -86,6 +86,15 @@ teams:
    - smana
    - yastij
    privacy: closed
+  sig-docs-hi-owners:
+    description: Admins for Hindi content


@zacharysarah Two questions regarding this team:

What is the sig-docs-*-owners team meant for? Is it for pinging the team on PRs?

What does Admins for <language> content signify? Asking this because we've generally used descriptions as Admins for <repo> as a description to teams...where the said team would get admin access on the repo.

@mittalyashu Please change the description to "Owners for Hindi content".

config/kubernetes/sig-docs/teams.yaml

nikhita · 2019-04-20T09:18:14Z

/assign @zacharysarah

zacharysarah · 2019-04-24T22:17:59Z

@nikhita 👋

OWNERS need to be added in the website repo first.

Please feel free to assign me to any k/website PR for Hindi OWNERS updates.

zacharysarah · 2019-04-25T23:13:28Z

@nikhita 👋

What is the sig-docs-*-owners team meant for? Is it for pinging the team on PRs?

Yes, exactly. It's to create a GitHub team for the people specified in k/website/OWNERS_ALIASES—specifically, as invoked in k/website/content/hi/OWNERS.

What does Admins for content signify? Asking this because we've generally used descriptions as Admins for as a description to teams...where the said team would get admin access on the repo.

We don't give out admin repo access, so—would Approvers be more consistent? If so, we should change all relevant team descriptions to match.

nikhita · 2019-04-28T14:40:58Z

We don't give out admin repo access, so—would Approvers be more consistent? If so, we should change all relevant team descriptions to match.

Yeah, I guess that would be cleaner. :)

mittalyashu · 2019-04-29T03:15:39Z

Do I also have to add the name of the docs localization admin?

  sig-docs-l10n-admins:
    description: Admins for localization projects
    members:
    - alexbrand # Spanish
    - bradamant3 # English
    - ClaudiaJKang # Korean
    - cstoku # Japanese
    - femrtnz # Portuguese
    - girikuncoro # Indonesian
    - gochist # Korean
    - hanjiayao # Chinese
    - irvifa # Indonesian
    - jaredbhatti # English 
    - jcjesus # Portuguese
    - markthink # Chinese
    - micheleberardi # Italian
    - raelga # Spanish
    - remyleone # French
    - rlenferink # Italian
    - tnir # Japanese
    - zacharysarah # English
    - zhangxiaoyu-zidif # Chinese
    privacy: closed

zacharysarah · 2019-04-29T23:11:26Z

@mittalyashu

Do I also have to add the name of the docs localization admin?

Yes please.

mittalyashu · 2019-05-01T02:32:33Z

Roger that.

zacharysarah · 2019-05-01T03:31:26Z

/ok-to-test

zacharysarah · 2019-05-01T04:03:32Z

@mittalyashu From the test log:

config_test.go:248: The team sig-docs-l10n-admins in org Kubernetes has an unsorted list of members
config_test.go:248: The team sig-docs-hi-owners in org Kubernetes has an unsorted list of members
config_test.go:248: The team sig-docs-hi-reviews in org Kubernetes has an unsorted list of members

Please alphabetize your lists.

mittalyashu · 2019-05-05T12:06:33Z

Done

mrbobbytables · 2019-05-05T12:21:08Z

The group sig-docs-l10n-admins is not alphabetized. Once that is done it should pass all the tests 😄

One last little thing after that, would you mind squashing your commits down? We try and keep the git history in k/org as clean as possible 👍

Thanks!

config/kubernetes/sig-docs/teams.yaml

zacharysarah · 2019-05-08T21:12:22Z

/ok-to-retest

zacharysarah · 2019-05-08T21:13:51Z

Now that kubernetes/website#13910 has merged, I think it's OK to lift the hold.

/hold cancel

zacharysarah · 2019-05-08T21:14:24Z

/test pull-org-test-all

nikhita · 2019-05-13T03:46:17Z

/uncc
/cc @mittalyashu

k8s-ci-robot · 2019-05-13T03:46:18Z

@nikhita: GitHub didn't allow me to request PR reviews from the following users: mittalyashu.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/uncc
/cc @mittalyashu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nikhita · 2019-05-13T03:46:51Z

oooops, wrong PR. too many windows open. 🤦‍♀️

mittalyashu · 2019-05-13T04:14:46Z

I have made the required changes, plz take forward @zacharysarah.

nikhita · 2019-05-13T04:16:47Z

@mittalyashu can you squash the commits into a single commit :)

* Create localization team for hindi * Add daminisatya & Rajakavitha1 to sig-docs-hi * Add hindi admin name in sig-docs-l10n-admins * Remove duplicate name

mittalyashu · 2019-05-13T07:26:07Z

Thank you @raelga for helping out with squashing commits.

zacharysarah · 2019-05-13T07:34:37Z

/lgtm
/approve

k8s-ci-robot · 2019-05-13T07:34:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mittalyashu, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~config/kubernetes/sig-docs/OWNERS~~ [zacharysarah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2019

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 20, 2019

k8s-ci-robot requested review from jaredbhatti and zacharysarah April 20, 2019 08:48

k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2019

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2019

nikhita reviewed Apr 20, 2019

View reviewed changes

config/kubernetes/sig-docs/teams.yaml Show resolved Hide resolved

k8s-ci-robot assigned zacharysarah Apr 20, 2019

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2019

nikhita mentioned this pull request Apr 28, 2019

Localise readme.md in hindi kubernetes/website#13910

Merged

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 1, 2019

nikhita mentioned this pull request May 5, 2019

sig-docs: fix description for admin teams #790

Merged

nikhita reviewed May 5, 2019

View reviewed changes

config/kubernetes/sig-docs/teams.yaml Show resolved Hide resolved

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2019

mittalyashu force-pushed the master branch from 1828db4 to d6274c8 Compare May 13, 2019 04:13

mittalyashu force-pushed the master branch from 4737b64 to 6b71959 Compare May 13, 2019 07:21

Add sig-docs-hi members

b70f483

* Create localization team for hindi * Add daminisatya & Rajakavitha1 to sig-docs-hi * Add hindi admin name in sig-docs-l10n-admins * Remove duplicate name

mittalyashu force-pushed the master branch from 6b71959 to b70f483 Compare May 13, 2019 07:25

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2019

k8s-ci-robot merged commit b495745 into kubernetes:master May 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sig-docs-hi members #748

Add sig-docs-hi members #748

mittalyashu commented Apr 20, 2019

k8s-ci-robot commented Apr 20, 2019

nikhita commented Apr 20, 2019

nikhita Apr 20, 2019

zacharysarah Apr 29, 2019

mittalyashu May 5, 2019

nikhita commented Apr 20, 2019

zacharysarah commented Apr 24, 2019

zacharysarah commented Apr 25, 2019

nikhita commented Apr 28, 2019

mittalyashu commented Apr 29, 2019

zacharysarah commented Apr 29, 2019

mittalyashu commented May 1, 2019

zacharysarah commented May 1, 2019

zacharysarah commented May 1, 2019

mittalyashu commented May 5, 2019

mrbobbytables commented May 5, 2019

zacharysarah commented May 8, 2019

zacharysarah commented May 8, 2019

zacharysarah commented May 8, 2019

nikhita commented May 13, 2019

k8s-ci-robot commented May 13, 2019

nikhita commented May 13, 2019

mittalyashu commented May 13, 2019

nikhita commented May 13, 2019

mittalyashu commented May 13, 2019

zacharysarah commented May 13, 2019

k8s-ci-robot commented May 13, 2019

Add sig-docs-hi members #748

Add sig-docs-hi members #748

Conversation

mittalyashu commented Apr 20, 2019

Refs

k8s-ci-robot commented Apr 20, 2019

nikhita commented Apr 20, 2019

nikhita Apr 20, 2019

Choose a reason for hiding this comment

zacharysarah Apr 29, 2019

Choose a reason for hiding this comment

mittalyashu May 5, 2019

Choose a reason for hiding this comment

nikhita commented Apr 20, 2019

zacharysarah commented Apr 24, 2019

zacharysarah commented Apr 25, 2019

nikhita commented Apr 28, 2019

mittalyashu commented Apr 29, 2019

zacharysarah commented Apr 29, 2019

mittalyashu commented May 1, 2019

zacharysarah commented May 1, 2019

zacharysarah commented May 1, 2019

mittalyashu commented May 5, 2019

mrbobbytables commented May 5, 2019

zacharysarah commented May 8, 2019

zacharysarah commented May 8, 2019

zacharysarah commented May 8, 2019

nikhita commented May 13, 2019

k8s-ci-robot commented May 13, 2019

nikhita commented May 13, 2019

mittalyashu commented May 13, 2019

nikhita commented May 13, 2019

mittalyashu commented May 13, 2019

zacharysarah commented May 13, 2019

k8s-ci-robot commented May 13, 2019