Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sig-docs-id PT speaking members to the team #729

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Add sig-docs-id PT speaking members to the team #729

merged 1 commit into from
Apr 17, 2019

Conversation

femrtnz
Copy link
Member

@femrtnz femrtnz commented Apr 16, 2019

Hi @rlenferink

please have a look at this PR as requested

Cheers
Felipe

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 16, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @femrtnz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 16, 2019
@femrtnz
Copy link
Member Author

femrtnz commented Apr 16, 2019

/assign @zacharysarah

Copy link

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@femrtnz 👋 Thanks for adding these! Please make sure the additions are in alphabetical order, otherwise LGTM.

config/kubernetes/sig-docs/teams.yaml Outdated Show resolved Hide resolved
config/kubernetes/sig-docs/teams.yaml Outdated Show resolved Hide resolved
config/kubernetes/sig-docs/teams.yaml Outdated Show resolved Hide resolved
@zacharysarah
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 16, 2019
@femrtnz
Copy link
Member Author

femrtnz commented Apr 16, 2019

/retest

@mrbobbytables
Copy link
Member

@femrtnz thanks for kick-starting the Portuguese localization efforts :)
Would you mind squashing the commits in this PR? We try and keep the git history in the org repo as clear as possible. 😬

Also, @jcjesus please submit an org membership request. Once you do, I'll cut a PR adding you and @femrtnz to the kubernetes org and it should unblock creating the sig-docs-pt team 🎉

Adding names in alphabetical order

Adding sig-docs- in alphabetical order
@mrbobbytables
Copy link
Member

/retest

@mrbobbytables
Copy link
Member

@femrtnzThanks for squashing it down. :)

With you and @jcjesus added it should be good to merge 👍

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: femrtnz, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 16ab2c7 into kubernetes:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants