Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hzxuzhonghu to kubernetes-sigs #708

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Add hzxuzhonghu to kubernetes-sigs #708

merged 1 commit into from
Apr 12, 2019

Conversation

hzxuzhonghu
Copy link
Member

fixes : #707

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2019
@hzxuzhonghu
Copy link
Member Author

/assign @nikhita

@cblecker
Copy link
Member

@hzxuzhonghu normally adding folks to the org is left to our membership coordinators, but as you're already in the @kubernetes org, you're automatically eligible for @kubernetes-sigs membership.

@hzxuzhonghu
Copy link
Member Author

Thanks for your clarification.

@justaugustus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2019
@nikhita
Copy link
Member

nikhita commented Apr 11, 2019

@hzxuzhonghu Can you edit the commit message to Add hzxuzhonghu to kubernetes-sigs instead of Add members 2019-04-11? There are some more membership requests and IMO it would be appropriate to bundle those into another PR which says Add members 2019-04-11.

@hzxuzhonghu hzxuzhonghu changed the title Add members 2019-04-11 Add hzxuzhonghu to kubernetes-sigs Apr 12, 2019
@hzxuzhonghu
Copy link
Member Author

@nikhita Done

@cblecker cblecker added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 12, 2019
@cblecker
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 33ed076 into kubernetes:master Apr 12, 2019
@hzxuzhonghu hzxuzhonghu deleted the patch-1 branch April 12, 2019 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@justaugustus justaugustus

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REQUEST: New membership for hzxuzhonghu
5 participants
@hzxuzhonghu @cblecker @justaugustus @nikhita @k8s-ci-robot