Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add members 2019-03-14 #607

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

mrbobbytables
Copy link
Member

@mrbobbytables mrbobbytables commented Mar 15, 2019

fixes #470
fixes #603

/area github-membership

/pony pie
it's π day :P

@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: pony image

In response to this:

fixes #470
fixes #603

/area github-management

/pony pie
it's π day :P

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 15, 2019
@k8s-ci-robot k8s-ci-robot added the area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team label Mar 15, 2019
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrbobbytables 💯 use of the pony plugin!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1faa02f into kubernetes:master Mar 15, 2019
@mrbobbytables mrbobbytables deleted the add-members-2019-03-14 branch March 18, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REQUEST: New membership for srampal REQUEST: New membership for sfzylad
3 participants