Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wg-lts leads owner alias and wg-lts team #604

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Add wg-lts leads owner alias and wg-lts team #604

merged 2 commits into from
Mar 15, 2019

Conversation

imkin
Copy link

@imkin imkin commented Mar 14, 2019 •
edited
Loading

Added the WG_LTS chairs/organizers to the leads alias

https://github.com/kubernetes/community/tree/master/wg-lts

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2019
@nikhita
Copy link
Member

nikhita commented Mar 14, 2019

The OWNERS_ALIASES file here is supposed to be a mirror/copy of https://github.com/kubernetes/community/blob/master/OWNERS_ALIASES.

Instead of selectively updating it, could you copy that file here? I think there were some more changes that were done recently. :)

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 14, 2019
@imkin
Copy link
Author

imkin commented Mar 14, 2019

@nikhita I see that the changes are not appropriate if I merge the OWNER ALIASES from the other repo.

@nikhita
Copy link
Member

nikhita commented Mar 14, 2019

Looks like both the OWNERS_ALIASES files have ended up diverging. Let's restrict this PR to wg-lts leads for now.

@nikhita
Copy link
Member

nikhita commented Mar 14, 2019

@imkin do you also intend on adding wg-lts teams in this PR? That way the alias will actually be used ;)

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2019
@imkin
Copy link
Author

imkin commented Mar 14, 2019

/cc @tpepper @quinton-hoole-2 @youngnick

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 14, 2019
k8s-ci-robot
k8s-ci-robot reviewed Mar 14, 2019
View reviewed changes
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imkin: 1 invalid OWNERS file

In response to this:

Added the WG_LTS chairs/organizers to the leads alias

https://github.com/kubernetes/community/tree/master/wg-lts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

config/kubernetes/wg-lts/OWNERS
@@ -0,0 +1,8 @@
# See the OWNERS docs at https://go.k8s.io/owners
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 9: could not find expected ':'.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2019
k8s-ci-robot
k8s-ci-robot reviewed Mar 14, 2019
View reviewed changes
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imkin: 1 invalid OWNERS file

In response to this:

Added the WG_LTS chairs/organizers to the leads alias

https://github.com/kubernetes/community/tree/master/wg-lts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

config/kubernetes/wg-lts/OWNERS
@@ -0,0 +1,8 @@
# See the OWNERS docs at https://go.k8s.io/owners
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 9: could not find expected ':'.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 14, 2019
@imkin
Copy link
Author

imkin commented Mar 14, 2019

@nikhita done.

@imkin imkin changed the title Add wg-lts leads owner alias Add wg-lts leads owner alias and wg-lts team Mar 14, 2019
nikhita
nikhita approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: approving since @imkin is a wg-lts lead.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imkin, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7e8fd0a into kubernetes:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k8s-ci-robot k8s-ci-robot k8s-ci-robot left review comments

@nikhita nikhita nikhita approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@spiffxp spiffxp Awaiting requested review from spiffxp

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

@tpepper tpepper Awaiting requested review from tpepper

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imkin @nikhita @k8s-ci-robot