Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update teams for sig-azure #601

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Conversation

feiskyer
Copy link
Member

  • Add missing teams for cloud-provider-azure repo
  • Update members for csi repos

/assign @justaugustus @cblecker

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider labels Mar 14, 2019
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit about the newline.

config/kubernetes-sigs/sig-azure/teams.yaml Outdated Show resolved Hide resolved
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit df074dc into kubernetes:master Mar 14, 2019
@justaugustus
Copy link
Member

@nikhita -- once this syncs, can you grant cloud-provider-azure-admins admin access and cloud-provider-azure-maintainers write access to k/cloud-provider-azure and remove any extraneous admins and collaborators?

@nikhita
Copy link
Member

nikhita commented Mar 14, 2019

@nikhita -- once this syncs, can you grant cloud-provider-azure-admins admin access and cloud-provider-azure-maintainers write access to k/cloud-provider-azure and remove any extraneous admins and collaborators?

Yup, will do! And I'll add a comment here confirming once it's done. :)

@justaugustus
Copy link
Member

Thank youuuu :)

@feiskyer feiskyer deleted the members branch March 14, 2019 09:40
@feiskyer
Copy link
Member Author

@nikhita @justaugustus thanks

@nikhita
Copy link
Member

nikhita commented Mar 14, 2019

@justaugustus @feiskyer done 🎉

There were also no extraneous admins and collaborators. Now, kubernetes/cloud-provider-azure-admins@ has admin access and kubernetes/cloud-provider-azure-maintainers@ has write access.

@justaugustus
Copy link
Member

Thanks again, Nikhita!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants