Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add brad as resizer repo admin #572

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Add brad as resizer repo admin #572

merged 1 commit into from
Mar 6, 2019

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Mar 6, 2019

Fixes #571

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2019
@gnufied gnufied mentioned this pull request Mar 6, 2019
Closed
nikhita
nikhita approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: lgtm'ing since @childsb is a sig-storage lead and @gnufied is an approver for external-resizer.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2019
@nikhita
Copy link
Member

nikhita commented Mar 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2019
@nikhita
Copy link
Member

nikhita commented Mar 6, 2019

/retest

@gnufied
Copy link
Member Author

gnufied commented Mar 6, 2019

It looks to be failing on:

o: golang.org/x/lint@v0.0.0-20180702182130-06c8688daad7: git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /home/prow/go/pkg/mod/cache/vcs/79f2695321bc515689ad880a6109a13399c003ff78670317e7d502240c43b765: exit status 128:
	fatal: remote error: Git repository not found
go: golang.org/x/text@v0.3.0: unknown revision v0.3.0
go: google.golang.org/api@v0.0.0-20181129220737-af4fc4062c26: git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /home/prow/go/pkg/mod/cache/vcs/9e62a95b0409d58bc0130bae299bdffbc7b7e74f3abe1ecf897474cc474b8bc0: exit status 128:
	fatal: remote error: Git repository not found
go: google.golang.org/api@v0.0.0-20180910000450-7ca32eb868bf: unknown revision 7ca32eb868bf
go: error loading module requirements

Seems unrelated to this PR.

@nikhita
Copy link
Member

nikhita commented Mar 6, 2019

👀 looks like a bad flake (came across this on #570 too)

/retest

@k8s-ci-robot k8s-ci-robot merged commit f29db76 into kubernetes:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnufied @k8s-ci-robot @nikhita