Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add admins for cloud-provider-alibaba repo #544

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

andrewsykim
Copy link
Member

Admins are based on people in the OWNERS file.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 28, 2019
@k8s-ci-robot k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Feb 28, 2019
@andrewsykim
Copy link
Member Author

cc @calebamiles

Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f44b5f7 into kubernetes:master Feb 28, 2019
@nikhita
Copy link
Member

nikhita commented Feb 28, 2019

@andrewsykim once the postsubmit runs and the teams are created, I'll grant admin powers to the team. 👍

@andrewsykim
Copy link
Member Author

Thank you!

@nikhita
Copy link
Member

nikhita commented Mar 1, 2019

@aoxn @cheyang @xlgao-zju you should now have admin privileges over https://github.com/kubernetes/cloud-provider-alibaba-cloud :)

@andrewsykim You had admin powers on the repo via being a part of kubernetes/sig-cloud-provider-admins@ + direct collaborator access. I removed you as a direct collaborator because we prefer to distribute priviliges using teams. You should still have admin powers on the repo though since you are part of the team. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants