Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add richabanker to sig-instrumentation-leads #5257

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Add richabanker to sig-instrumentation-leads #5257

merged 1 commit into from
Dec 13, 2024

Conversation

richabanker
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Nov 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2024
logicalhan
logicalhan approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2024
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 18, 2024
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
@richabanker richabanker force-pushed the ownership-change branch 2 times, most recently from bb02989 to 8c4a54d Compare November 18, 2024 20:10
@richabanker richabanker mentioned this pull request Nov 18, 2024
Open
17 tasks
@richabanker
Copy link
Contributor Author

/assign @cblecker

logicalhan
logicalhan approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2024
@Priyankasaggu11929
Copy link
Member

/approve

/hold
(please unhold, if ready to merge. Thank you 🙂 )

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicalhan, Priyankasaggu11929, richabanker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2024
@Priyankasaggu11929
Copy link
Member

Ping @richabanker, @logicalhan – checking if we're fine removing the hold here? 🙂

@richabanker
Copy link
Contributor Author

@Priyankasaggu11929 yeah I think we should be good to unhold.
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6123dc5 into kubernetes:main Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan approved these changes

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@logicalhan logicalhan

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richabanker @Priyankasaggu11929 @k8s-ci-robot @logicalhan @cblecker