Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add etcd release team #5068

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add etcd release team #5068

merged 1 commit into from
Aug 5, 2024

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Jul 16, 2024

We (sig-etcd leads) are creating a new GitHub team within our etcd-io org for the release team.

The members of this team will act as leads or advisors for upcoming etcd releases, on an agreed rotation and have repository write permissions to carry out etcd-io/etcd releases.

Historically etcd releases have only been carried out by maintainers which is challenging due to our currently small number of project maintainers. We've been gradually making improvements over time to address this, through improving our release processes, introducing release shadow roles and rotating the release manager for each release.

We now think the time is right to extend the release team beyond maintainers, to also include reviewers, as reviewers are all future maintainers for etcd that we have a lot of trust and confidence in.

cc @wenjiaswe, @ahrtr, @serathius

Signed-off-by: James Blair <mail@jamesblair.net>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2024
repos:
# Permission set to triage during bau activities
# During release windows this will be bumped to `maintain`
etcd: triage
Copy link
Member Author

@jmhbnz jmhbnz Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can easily bump this when a release is planned as sig-etcd-leads are OWNERS to /lgtm /approve a pr from a reviewer to bump it for the release then it can be reverted to bau afterward.

This ensures principle of least privileges is maintained.

@ahrtr
Copy link
Member

ahrtr commented Jul 17, 2024

/lgtm
/approve

/hold

Thanks @jmhbnz for driving this. Please feel free to un-hold after other maintainers reviewed this PR.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2024
@wenjiaswe
Copy link

/lgtm
/approve

Thank you! @jmhbnz

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, wenjiaswe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz
Copy link
Member Author

jmhbnz commented Aug 5, 2024

Unholding after three business weeks for lazy consensus
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 68bc362 into kubernetes:main Aug 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants