-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes-admins group to help fight spam #4994
base: main
Are you sure you want to change the base?
kubernetes-admins group to help fight spam #4994
Conversation
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering @dims proactive yeoman work, this is a blindfolded yes
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, jasonbraganza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold will also wait for the other, more experienced folk, to weigh in |
I am okay with this only if we can absolutely not come up with an alternative. I would prefer not adding admin privileges beyond the set of GH admins and required bots. One solution that I am currently tinkering with is since the k8s-ci-robot has admin access already, a prow plugin that can recognise comments like |
works for me! |
volunteering ✋🏾 to help cleanup spam. Deleting issues needs
admin
privs.context some recent pokes to github admins for cleanup: