Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubespray/maintainers: add VannTeen #4993

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

ant31
Copy link
Member

@ant31 ant31 commented May 31, 2024

Hi all,

@VannTen has been a core maintainer of kubernetes-sigs/kubespray some time now, and he made significant contribution🥳.
It will help us manging the repo/issues to add him to our github team !
image

Best,
Antoine

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2024
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2024
@ant31
Copy link
Member Author

ant31 commented Jun 4, 2024

/assign @Priyankasaggu11929

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 4, 2024

/lgtm
/approve

/hold
(for another review/approve from @bridgetkromhout, @kubernetes/sig-cloud-provider-leads)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 4, 2024
@Priyankasaggu11929
Copy link
Member

correction:

need review/approval from @kubernetes/sig-cluster-lifecycle-leads. Thanks!

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ant31, neolit123, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ant31
Copy link
Member Author

ant31 commented Jun 4, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2024
@ant31
Copy link
Member Author

ant31 commented Jun 4, 2024

Thank you !

@k8s-ci-robot k8s-ci-robot merged commit 72162e4 into kubernetes:main Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants