Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release Signal Shadows to the team #4989

Closed
wants to merge 1 commit into from

Conversation

Vyom-Yadav
Copy link
Member

  • Added v1.31 release signal shadows to the team.
  • Added @SubhasmitaSw to milestone maintainers (more experienced shadow), removed prev. shadow @MaryamTavakkoli

/cc @Priyankasaggu11929 @neoaggelos
/cc @Atharva-Shinde @SubhasmitaSw @wendy-ha18 @AdminTurnedDevOps

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 29, 2024
@k8s-ci-robot
Copy link
Contributor

@Vyom-Yadav: GitHub didn't allow me to request PR reviews from the following users: wendy-ha18.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

  • Added v1.31 release signal shadows to the team.
  • Added @SubhasmitaSw to milestone maintainers (more experienced shadow), removed prev. shadow @MaryamTavakkoli

/cc @Priyankasaggu11929 @neoaggelos
/cc @Atharva-Shinde @SubhasmitaSw @wendy-ha18 @AdminTurnedDevOps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label May 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Vyom-Yadav
Once this PR has been reviewed and has the lgtm label, please assign puerco for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2024
Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com>
@Priyankasaggu11929
Copy link
Member

@Vyom-Yadav, PR #4936 is adding all 1.31 different role's shadows together.

Let's use that PR for Release Signal shadows changes too.

@Priyankasaggu11929
Copy link
Member

#4936 is merged now.
Shadows are added to the required gh teams.

Closing this PR.
/close

@k8s-ci-robot
Copy link
Contributor

@Priyankasaggu11929: Closed this PR.

In response to this:

#4936 is merged now.
Shadows are added to the required gh teams.

Closing this PR.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants