Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add members 2024-05-17 #4954

Merged
merged 1 commit into from
May 17, 2024
Merged

Add members 2024-05-17 #4954

merged 1 commit into from
May 17, 2024
+1 −0

Conversation

ydFu
Copy link
Member

@ydFu ydFu commented May 17, 2024

This PR:

/area github-membership

@k8s-ci-robot k8s-ci-robot added area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2024
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2024
@ydFu ydFu mentioned this pull request May 17, 2024
Closed
11 tasks
@ydFu
Copy link
Member Author

ydFu commented May 17, 2024

/retest-required

nikhita
nikhita approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, ydFu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@nikhita
Copy link
Member

nikhita commented May 17, 2024 

config_test.go:263: members for Kubernetes org are unsorted

The list needs to be sorted

@ydFu
Add members 2024-05-17
505f604 
Signed-off-by: ydFu <ader.ydfu@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@ydFu
Copy link
Member Author

ydFu commented May 17, 2024 

config_test.go:263: members for Kubernetes org are unsorted

The list needs to be sorted

Thanks for the reminder, the adjustment has been completed.

@Priyankasaggu11929
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4d56702 into kubernetes:main May 17, 2024
4 checks passed
@ydFu ydFu deleted the add-05-17 branch May 17, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

@jasonbraganza jasonbraganza Awaiting requested review from jasonbraganza

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@nikhita nikhita

@Priyankasaggu11929 Priyankasaggu11929

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REQUEST: New membership for adilGhaffarDev
4 participants
@ydFu @k8s-ci-robot @nikhita @Priyankasaggu11929