Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-storage: add team repo permissions for external-snapshot-metadata repo #4899

Merged

Conversation

Priyankasaggu11929
Copy link
Member

Ref: #4874

/assign @kubernetes/sig-storage-leads

cc: @kubernetes/owners

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 24, 2024
@Priyankasaggu11929
Copy link
Member Author

@xing-yang@carlbraganza and @PrasadG193 will need requesting new org membership before the tool allows them to add to a GH team.

 --- FAIL: TestAllOrgs (0.08s)
    config_test.go:268: The following members of team external-snapshot-metadata-maintainers are not Kubernetes CSI org members: carlbraganza, prasadg193
    config_test.go:268: The following members of team external-snapshot-metadata-admins are not Kubernetes CSI org members: carlbraganza, prasadg193 

Do you suggest to (i) move ahead with this PR & add @carlbraganza, @PrasadG193 later once the org membership requests are processed, or (ii) wait?

@xing-yang
Copy link
Contributor

@Priyankasaggu11929 Sorry, I missed this earlier. Please go ahead with this PR and we can add @carlbraganza, @PrasadG193 later. Thanks!

@Priyankasaggu11929
Copy link
Member Author

Thanks @xing-yang.

I've refreshed the PR. Ready to lgtm/approve.

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 079b506 into kubernetes:main May 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants