-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1.30 Docs Shadows to GitHub teams #4690
Add 1.30 Docs Shadows to GitHub teams #4690
Conversation
/retest |
We need to create an issue in |
Hi @drewhagen, a couple of small things:
The entries should be in alphabetical order, that should fix it.
The corresponding membership request needs to be opened and approved before this can be merged. |
@fsmunoz Thanks for the reminder! I pushed a commit to alphabetize the shadows and I reached out to Daniel about registering for the K8s org. EDIT: Now I pushed a second commit to make sure both files are alphabetized. |
job failed because @chanieljdan is not a Kubernetes org member @drewhagen , you can add @chanieljdan in a later PR when @chanieljdan is an org member or wait until @chanieljdan is an org member |
@drewhagen perfect, that only leaves the issue of @chanieljdan org membership, as @reylejano said, either remove it from now and then open another PR for that specific addition, or wait until that is processed. I took the liberty of looking at the opened issues against kubernetes/org and I don't see their request there, so opening it would be a priority. |
Here is the issue requesting membership: I'll take y'all's advice of opening another PR while waiting |
/lgtm |
/approve |
/assign @natalisucks |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: drewhagen, justaugustus, katcosgrove, natalisucks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this:
/kind documentation
What this PR does / why we need it:
Add 1.30 Docs Shadows to sig-docs and sig-release teams
/assign @katcosgrove @gracenng @neoaggelos @ramrodo @sanchita-07 @fsmunoz