Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.30 Docs Shadows to GitHub teams #4690

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

drewhagen
Copy link
Member

@drewhagen drewhagen commented Jan 17, 2024

What type of PR is this:

/kind documentation

What this PR does / why we need it:

Add 1.30 Docs Shadows to sig-docs and sig-release teams

/assign @katcosgrove @gracenng @neoaggelos @ramrodo @sanchita-07 @fsmunoz

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 17, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2024
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2024
@drewhagen
Copy link
Member Author

/retest

@sanchita-07
Copy link
Member

We need to create an issue in kubernetes/org repository requesting membership for @chanieljdan in kubernetes org.

@fsmunoz
Copy link
Contributor

fsmunoz commented Jan 18, 2024

Hi @drewhagen, a couple of small things:

The team release-team-docs in org Kubernetes has an unsorted list of members

The entries should be in alphabetical order, that should fix it.

The following members of team website-milestone-maintainers are not Kubernetes org members: chanieljdan

The corresponding membership request needs to be opened and approved before this can be merged.

@drewhagen
Copy link
Member Author

drewhagen commented Jan 19, 2024

@fsmunoz Thanks for the reminder! I pushed a commit to alphabetize the shadows and I reached out to Daniel about registering for the K8s org.

EDIT: Now I pushed a second commit to make sure both files are alphabetized.

@reylejano
Copy link
Member

job failed because @chanieljdan is not a Kubernetes org member

@drewhagen , you can add @chanieljdan in a later PR when @chanieljdan is an org member or wait until @chanieljdan is an org member

@fsmunoz
Copy link
Contributor

fsmunoz commented Jan 19, 2024

@drewhagen perfect, that only leaves the issue of @chanieljdan org membership, as @reylejano said, either remove it from now and then open another PR for that specific addition, or wait until that is processed. I took the liberty of looking at the opened issues against kubernetes/org and I don't see their request there, so opening it would be a priority.

@drewhagen
Copy link
Member Author

Here is the issue requesting membership:
#4699

I'll take y'all's advice of opening another PR while waiting

@reylejano
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2024
@katcosgrove
Copy link
Contributor

/approve

@katcosgrove
Copy link
Contributor

/assign @natalisucks
/assign @puerco

@natalisucks
Copy link

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drewhagen, justaugustus, katcosgrove, natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit ea333a7 into kubernetes:main Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.