Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1.30 Release Team Permissions #4643

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Add 1.30 Release Team Permissions #4643

merged 6 commits into from
Jan 3, 2024

Conversation

katcosgrove
Copy link
Contributor

Initial PR to add RT Lead and Subteam Leads for v1.30.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jan 2, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 2, 2024
@katcosgrove katcosgrove mentioned this pull request Jan 2, 2024
Closed
Priyankasaggu11929
Priyankasaggu11929 requested changes Jan 3, 2024
View reviewed changes
config/kubernetes/sig-release/teams.yaml Show resolved Hide resolved
config/kubernetes/sig-release/teams.yaml Outdated Show resolved Hide resolved
config/kubernetes/sig-release/teams.yaml Show resolved Hide resolved
config/kubernetes/sig-release/teams.yaml Outdated Show resolved Hide resolved
config/kubernetes/sig-release/teams.yaml Show resolved Hide resolved
@Priyankasaggu11929
Copy link
Member

@katcosgrove @gracenng, how about we merge the existing ci-signal and release-team-bug-triage GH teams, to a new release-team-release-signal team (to align with our new release team structure change, and avoid duplicating same team members across 2 teams)

          release-team-release-signal:
            description: Members of the Release Signal team for the current release cycle.
            members:
            - pacoxu # 1.30 Release Signal Lead
            # - X # 1.30 Bug Triage Shadow
            # - X # 1.30 Bug Triage Shadow
            # - X # 1.30 Bug Triage Shadow
            # - X # 1.30 Bug Triage Shadow

@katcosgrove
Copy link
Contributor Author

@katcosgrove @gracenng, how about we merge the existing ci-signal and release-team-bug-triage GH teams, to a new release-team-release-signal team (to align with our new release team structure change, and avoid duplicating same team members across 2 teams)

          release-team-release-signal:
            description: Members of the Release Signal team for the current release cycle.
            members:
            - pacoxu # 1.30 Release Signal Lead
            # - X # 1.30 Bug Triage Shadow
            # - X # 1.30 Bug Triage Shadow
            # - X # 1.30 Bug Triage Shadow
            # - X # 1.30 Bug Triage Shadow

Done!

@Priyankasaggu11929
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: katcosgrove, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 867a30d into kubernetes:main Jan 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Priyankasaggu11929 Priyankasaggu11929 Priyankasaggu11929 requested changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@Verolop Verolop Awaiting requested review from Verolop

Assignees

@Priyankasaggu11929 Priyankasaggu11929

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katcosgrove @Priyankasaggu11929 @k8s-ci-robot