Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add martinforreal to kubernetes-csi org #4447

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Add martinforreal to kubernetes-csi org #4447

merged 1 commit into from
Sep 30, 2023

Conversation

MartinForReal
Copy link
Contributor

@MartinForReal MartinForReal commented Sep 11, 2023 •
edited
Loading

/area github-membership

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Sep 11, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2023
@MartinForReal
Copy link
Contributor Author

/assign @MadhavJivrajani

palnabarun
palnabarun requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please correct the case for the username in the PR and the commit?

config/kubernetes-csi/org.yaml Outdated Show resolved Hide resolved
@hakman
Copy link
Member

hakman commented Sep 29, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2023
@Priyankasaggu11929
Copy link
Member

/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinForReal, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit e23d0a7 into kubernetes:main Sep 30, 2023
3 checks passed
@MartinForReal MartinForReal deleted the patch-1 branch October 2, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palnabarun palnabarun palnabarun requested changes

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

Assignees

@hakman hakman

@MadhavJivrajani MadhavJivrajani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MartinForReal @hakman @Priyankasaggu11929 @k8s-ci-robot @palnabarun @MadhavJivrajani