Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priyankasaggu11929 as GitHub Admin #4388

Conversation

Priyankasaggu11929
Copy link
Member

@Priyankasaggu11929 Priyankasaggu11929 commented Aug 15, 2023

Ref kubernetes/community#7464

Commit 1

.*: add Priyankasaggu11929 and rotate out idvoretskyi as admin

Change root OWNERS and ADMIN variables in scripts.

Commit 2

remove Priyankasaggu11929 from wg-structured-logging teams.yaml

Commit 3

config: GH admin rotation - update team configs

Move idvoretskyi to members wherever applicable.
Add Priyankasaggu11929 as maintainer anew or move from member to maintainer wherever necessary.

Commit 4

config: GH Admin rotation - upgrade org OWNERS and configs

Add Priyankasaggu11929 as admin in all orgs and move idvoretskyi to member wherever applicable.
Add Priyankasaggu11929 as reviewer and approver in OWNERS of all orgs and move idvoretskyi to emiratus.

/cc https://github.com/orgs/kubernetes/teams/owners
/assign @nikhita

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2023
@Priyankasaggu11929
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2023
Add Priyankasaggu11929 as admin in all orgs and move idvoretskyi to member wherever applicable.

Add Priyankasaggu11929 as reviewer and approver in OWNERS of
all orgs and move idvoretskyi to emiratus.
@nikhita
Copy link
Member

nikhita commented Aug 15, 2023

Lgtm after rebase

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2023
Move idvoretskyi to members wherever applicable.

Add Priyankasaggu11929 as maintainer anew or move from member to maintainer wherever necessary.
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 15, 2023
@Priyankasaggu11929
Copy link
Member Author

@nikhita, rebased the PR. PTAL. Thanks! 🙂

Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Congratulations!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@nikhita
Copy link
Member

nikhita commented Aug 15, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit f7ced6a into kubernetes:main Aug 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants