Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add members 20230803 #4366

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Add members 20230803 #4366

merged 2 commits into from
Aug 4, 2023

Conversation

mrbobbytables
Copy link
Member

fixes: #4181
fixes: #4361

/area github-membership

@k8s-ci-robot k8s-ci-robot added area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 3, 2023
@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Aug 3, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2023
@mrbobbytables
Copy link
Member Author

/hold
double checking something

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
This was referenced Aug 3, 2023
Closed
Closed
@mrbobbytables
Copy link
Member Author

okay, should be good -
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
palnabarun
palnabarun approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 01547bd into kubernetes:main Aug 4, 2023
@mrbobbytables mrbobbytables deleted the add-members-20230803 branch November 13, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palnabarun palnabarun palnabarun approved these changes

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

Assignees

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REQUEST: New membership for mjlshen REQUEST: New membership for @coulof
3 participants
@mrbobbytables @k8s-ci-robot @palnabarun