-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin: tell peribolos to reconcile team repo permissions #4359
admin: tell peribolos to reconcile team repo permissions #4359
Conversation
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
Thanks for catching this, Madhav. 🙂 (Just a note for later) I learnt about the flag /lgtm @MadhavJivrajani, will wait for Nikhita (as one of the GH admins) to remove the hold. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MadhavJivrajani, nikhita, palnabarun, Priyankasaggu11929 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We now have the ability to manage team repo permissions with a restrictions model using peribolos as part of #2614
But from the logs of the latest peribolos run:
This is because the flag that actually tells peribolos to reconcile team repo permissions (
--fix-team-repos
) was not set.This commit rectifies that.
/assign @nikhita @Priyankasaggu11929
/hold
/sig contributor-experience