-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
korg: add audit command #4291
korg: add audit command #4291
Conversation
/hold |
/assign /assign @MadhavJivrajani @Priyankasaggu11929 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor suggestions and questions.
Overall, looks great! Thank you @palnabarun, this is going to be very handy ❤️
Also — it would be useful to include this example exceptions file as well in the PR. Both for format reference and maybe as a default entries for bot accounts? ( |
There is a special case that not sure if we want to make a flag. https://go.k8s.io/owners/liu-cong is in the owner file but is emeritus. For such cases, we don't need an owner cleanup. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
78918dd
to
c63cdc4
Compare
@MadhavJivrajani The idea is good. I think it is taken care of already. Peribolos occasionally fails to reconcile if an invalid user exists in our manifests. Wondering if that is a sufficient lazy check. @Priyankasaggu11929 @MadhavJivrajani @pacoxu I resolved all your pending comments and regenerated the lists. Functionality diff from previous version:
|
/remove-lifecycle stale |
4717fdf
to
ba7db3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few non-blocking comments, LGTM otherwise!
I think this should suffice, thanks for reminding me about that 👍🏼 |
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
ba7db3a
to
245e550
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MadhavJivrajani, palnabarun, Priyankasaggu11929 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Good job. My last run two months ago resulted in a long list. |
Implements the audit command
Top level logic
Example
Running the following with this exceptions file after checking out this branch will give this table of users to be removed.
Follow-ups