Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Descheduler teams to reflect active maintainers #4162

Merged

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Apr 13, 2023

This updates the maintainer/admin teams for https://github.com/kubernetes-sigs/descheduler to reflect active maintainers.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Apr 13, 2023
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2023
Comment on lines 25 to 28
- a7i
- damemi
- ingvagabund
- k82cn
- ravisantoshgudimetla
- knelasevero
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why so many contributors with write access, as opposed to just approval rights?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey sorry for the delay on this. Our goal is to have more active maintainers who have access to publish releases (mainly pushing git tags to the repo). I copied this list from the current list of approvers in the repo. But we could probably shorten it if this is too broad

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write access could be dangerous, so I would be cautious about who has the permissions. Ultimately it's your decision as TL for descheduler, but I wanted to make sure you considered this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a valid point. I updated this change to only add @a7i as a writer (he is actively working on publishing this release).

We have an action item to automate our release process, so we will follow up with this to reduce the number of people with direct write access.

@damemi damemi force-pushed the descheduler-update-maintainers branch from df784e4 to d9ff5cb Compare May 3, 2023 14:35
@alculquicondor
Copy link
Member

/approve

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit c856473 into kubernetes:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants