-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Descheduler teams to reflect active maintainers #4162
Update Descheduler teams to reflect active maintainers #4162
Conversation
- a7i | ||
- damemi | ||
- ingvagabund | ||
- k82cn | ||
- ravisantoshgudimetla | ||
- knelasevero |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why so many contributors with write access, as opposed to just approval rights?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey sorry for the delay on this. Our goal is to have more active maintainers who have access to publish releases (mainly pushing git tags to the repo). I copied this list from the current list of approvers in the repo. But we could probably shorten it if this is too broad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write access could be dangerous, so I would be cautious about who has the permissions. Ultimately it's your decision as TL for descheduler, but I wanted to make sure you considered this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a valid point. I updated this change to only add @a7i as a writer (he is actively working on publishing this release).
We have an action item to automate our release process, so we will follow up with this to reduce the number of people with direct write access.
df784e4
to
d9ff5cb
Compare
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This updates the maintainer/admin teams for https://github.com/kubernetes-sigs/descheduler to reflect active maintainers.
descheduler-admins
(repo admin access)descheduler-maintainers
(repo write access)