Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sig-cli teams #391

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Update sig-cli teams #391

merged 1 commit into from
Jan 24, 2019

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jan 21, 2019

This updates sig-cli teams based on who's currently leading the SIG.

/assign @cblecker
/cc @pwittrock @seans3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 21, 2019
@nikhita
Copy link
Member

nikhita commented Jan 21, 2019 

--- FAIL: TestAllOrgs (0.06s)
    config_test.go:248: The team sig-cli-maintainers in org Kubernetes has an unsorted list of maintainers
    config_test.go:248: The team sig-cli-api-reviews in org Kubernetes has an unsorted list of members
    config_test.go:248: The team sig-cli-pr-reviews in org Kubernetes has users in both maintainer admin and member roles: soltysh
FAIL

@soltysh
Copy link
Contributor Author

soltysh commented Jan 23, 2019

@nikhita thanks, updated.

@nikhita
Copy link
Member

nikhita commented Jan 23, 2019

Lgtm'ing because changes make sense as per the current leads.
/lgtm

@soltysh Adding a hold in case you want to wait for someone from sig-cli to lgtm it.
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 23, 2019
@seans3
Copy link
Contributor

seans3 commented Jan 23, 2019

/lgtm

@soltysh
Copy link
Contributor Author

soltysh commented Jan 24, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 824f6b5 into kubernetes:master Jan 24, 2019
@soltysh soltysh deleted the sig-cli branch January 24, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwittrock pwittrock Awaiting requested review from pwittrock

@seans3 seans3 Awaiting requested review from seans3

Assignees

@cblecker cblecker

@seans3 seans3

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@soltysh @k8s-ci-robot @nikhita @seans3 @cblecker