-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup sig-instrumentation teams #3856
Cleanup sig-instrumentation teams #3856
Conversation
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
2e64b87
to
0b64c80
Compare
klog-admins: | ||
description: Admin access to the klog repo | ||
members: | ||
- dims | ||
- serathius | ||
- thockin | ||
privacy: closed | ||
klog-maintainers: | ||
description: Write access to the klog repo | ||
members: | ||
- dims | ||
- serathius | ||
- thockin | ||
privacy: closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@serathius do these updated klog teams looks good to you? It was updated to reflect the current OWNERS file in klog: https://github.com/kubernetes/klog/blob/main/OWNERS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/assign @cblecker |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, dgrisonnet, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @logicalhan @ehashman @dashpole