Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update my userid #3797

Closed
wants to merge 3 commits into from
Closed

update my userid #3797

wants to merge 3 commits into from
+6 −6

Conversation

arahamad
Copy link
Contributor

please update my userid

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 31, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Oct 31, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. area/provider/ibmcloud Issues or PRs related to ibmcloud provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Oct 31, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @arahamad!

It looks like this is your first PR to kubernetes/org 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/org has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @arahamad. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2022
@arahamad
Copy link
Contributor Author

/assign @spzala

mrbobbytables
mrbobbytables reviewed Oct 31, 2022
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arahamad you need to update your org membership name in addition to teams.
It also looks like you need to resign the CLA before things can proceed

@spzala
Copy link
Member

spzala commented Oct 31, 2022

@arahamad you need to update your org membership name in addition to teams. It also looks like you need to resign the CLA before things can proceed
Thanks Bob, yes he is working on it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 3, 2022
@arahamad
Copy link
Contributor Author

arahamad commented Nov 3, 2022

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@arahamad: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arahamad
Copy link
Contributor Author

arahamad commented Nov 3, 2022

@mrbobbytables , CLA is done

spzala
spzala reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2022
@mrbobbytables
Copy link
Member

mrbobbytables commented Nov 3, 2022 •
edited
Loading

please make the changes to all the org.yaml files and update the original commit message to be rename org member: arahamad-zz to arahamad

https://github.com/kubernetes/org/search?q=arahamad-zz

/tide merge-method-squash

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arahamad
Once this PR has been reviewed and has the lgtm label, please assign idvoretskyi for approval by writing /assign @idvoretskyi in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2022
@arahamad
Copy link
Contributor Author

arahamad commented Nov 3, 2022

@mrbobbytables , can you please review

@mrbobbytables
Copy link
Member

can you rebase/squash it so the original commit (4317c80) has the commit msg I suggested? we're sort of particular about the wording on this stuff as this is essentially the log of all org membership changes

@arahamad
Copy link
Contributor Author

arahamad commented Nov 3, 2022

closing this and opening a new PR

@arahamad arahamad closed this Nov 3, 2022
@arahamad
Copy link
Contributor Author

arahamad commented Nov 3, 2022

new PR #3813 for the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbobbytables mrbobbytables mrbobbytables left review comments

@spzala spzala spzala left review comments

@palnabarun palnabarun Awaiting requested review from palnabarun

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

Assignees

@spzala spzala

Labels
area/github-management Issues or PRs related to GitHub Management subproject area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arahamad @k8s-ci-robot @spzala @mrbobbytables