Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update teams.yaml #3738

Closed
wants to merge 2 commits into from
Closed

Update teams.yaml #3738

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7468844
Update the name
Nivedita-coder Sep 29, 2022
296414b
added required changes
Nivedita-coder Jun 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update the name
  • Loading branch information
@Nivedita-coder
Nivedita-coder committed Sep 29, 2022
commit 7468844ec10af56bedcacb3ffabd8e5390f4b82a
2 changes: 1 addition & 1 deletion config/kubernetes/sig-release/teams.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ teams:
- xmudrii # Release Manager
privacy: closed
teams:
ci-signal:
release-team-ci-signal:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name of the team can't be changed directly like this. It needs to add a previously

org/config/kubernetes/sig-architecture/teams.yaml

Lines 70 to 71 in f8b8c12

previously:
- features-maintainers

Also please make the commit message a bit more clear than 'update the name'.

description: Members of the CI Signal team for the current release
cycle.
members:
Expand Down