Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isSorted function in tests #372

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Fix isSorted function in tests #372

merged 1 commit into from
Jan 17, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jan 16, 2019

The List() method creates a sorted list. 😐

org/config/config_test.go

Lines 83 to 91 in 45f511f

func isSorted(list sets.String) bool {
items := make([]string, list.Len())
all := list.List()
for _, l := range all {
items = append(items, strings.ToLower(l))
}
return sort.StringsAreSorted(items)
}

This was introduced in #350, so this PR reverts the change to the isSorted function.

/kind bug
/assign @cblecker @fejta

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2019
@nikhita
Copy link
Member Author

nikhita commented Jan 16, 2019

Found this while trying to sort the list of team members and maintainers. Haven't added that change yet, because that list of unsorted maintainers and members is huge.

Such teams. Very unsorted. 
--- FAIL: TestAllOrgs (0.04s)
    config_test.go:249: The team drivers-admins has an unsorted list members
    config_test.go:249: The team developers has an unsorted list members
    config_test.go:249: The team csi-test-admins has an unsorted list members
    config_test.go:249: The team driver-registrar-admins has an unsorted list members
    config_test.go:249: The team external-provisioner-admins has an unsorted list members
    config_test.go:249: The team maintainers-apiserver-builder has an unsorted list maintainers
    config_test.go:249: The team maintainers-apiserver-builder has an unsorted list members
    config_test.go:249: The team maintainers-cri-containerd has an unsorted list members
    config_test.go:249: The team maintainers-bootkube has an unsorted list members
    config_test.go:249: The team maintainers-kompose has an unsorted list members
    config_test.go:249: The team maintainers-kube2consul has an unsorted list maintainers
    config_test.go:249: The team admins-external-dns has an unsorted list maintainers
    config_test.go:249: The team admins-apiserver-builder has an unsorted list members
    config_test.go:249: The team design-reviewer-kube-arbitrator has an unsorted list members
    config_test.go:249: The team kompose-contributors has an unsorted list members
    config_test.go:249: The team maintainers-client-python has an unsorted list members
    config_test.go:249: The team admin-cluster-capacity has an unsorted list members
    config_test.go:249: The team admin-cri-containerd has an unsorted list members
    config_test.go:249: The team admins-ip-masq-agent has an unsorted list maintainers
    config_test.go:249: The team maintainers-kube-aws has an unsorted list members
    config_test.go:249: The team maintainers-service-catalog has an unsorted list maintainers
    config_test.go:249: The team maintainers-service-catalog has an unsorted list members
    config_test.go:249: The team admins-kube2consul has an unsorted list maintainers
    config_test.go:249: The team maintainers-metrics-server has an unsorted list members
    config_test.go:249: The team owners has an unsorted list maintainers
    config_test.go:249: The team owners has an unsorted list members
    config_test.go:249: The team maintainers-external-dns has an unsorted list members
    config_test.go:249: The team external-storage-community has an unsorted list members
    config_test.go:249: The team maintainers-cluster-capacity has an unsorted list members
    config_test.go:249: The team admins-metrics-server has an unsorted list members
    config_test.go:249: The team maintainers-external-storage has an unsorted list members
    config_test.go:249: The team maintainers-ip-masq-agent has an unsorted list members
    config_test.go:249: The team admins-kargo has an unsorted list maintainers
    config_test.go:249: The team admins-kargo has an unsorted list members
    config_test.go:249: The team admins-kompose has an unsorted list members
    config_test.go:249: The team maintainers-cluster-proportional-vertical-autoscaler has an unsorted list members
    config_test.go:249: The team maintainers-kargo has an unsorted list maintainers
    config_test.go:249: The team maintainers-kargo has an unsorted list members
    config_test.go:249: The team maintainers-node-feature-discovery has an unsorted list members
    config_test.go:249: The team maintainers-spartakus has an unsorted list members
    config_test.go:249: The team admin-external-storage has an unsorted list members
    config_test.go:249: The team reviewers-cri-containerd has an unsorted list members
    config_test.go:249: The team admins-node-feature-discovery has an unsorted list members
    config_test.go:249: The team temporary-admin-transfers has an unsorted list members
    config_test.go:249: The team admins-service-catalog has an unsorted list maintainers
    config_test.go:249: The team admins-service-catalog has an unsorted list members
    config_test.go:249: The team kubernetes/sig-apps has an unsorted list members
    config_test.go:249: The team sig-storage-local-static-provisioner-admins has an unsorted list maintainers
    config_test.go:249: The team kube-batch-admins has an unsorted list maintainers
    config_test.go:249: The team kube-batch-admins has an unsorted list members
    config_test.go:249: The team structured-merge-diff-maintainers has an unsorted list maintainers
    config_test.go:249: The team yaml-admins has an unsorted list maintainers
    config_test.go:249: The team controller-runtime-contributors has an unsorted list members
    config_test.go:249: The team gcp-filestore-csi-driver-maintainers has an unsorted list maintainers
    config_test.go:249: The team website-metadata-maintainers has an unsorted list maintainers
    config_test.go:249: The team federation-wg has an unsorted list members
    config_test.go:249: The team kubernetes/sig-api-machinery has an unsorted list members
    config_test.go:249: The team kubernetes/sig-api-machinery-admins has an unsorted list members
    config_test.go:249: The team kubernetes/sig-api-machinery-approvers has an unsorted list members
    config_test.go:249: The team kubernetes/sig-api-machinery-reviewers has an unsorted list members
    config_test.go:249: The team bots has an unsorted list maintainers
    config_test.go:249: The team cri-tools-maintainers has an unsorted list maintainers
    config_test.go:249: The team gcp-filestore-csi-driver-admins has an unsorted list maintainers
    config_test.go:249: The team website-metadata-admins has an unsorted list maintainers
    config_test.go:249: The team cluster-api-provider-digitalocean-admins has an unsorted list maintainers
    config_test.go:249: The team structured-merge-diff-admins has an unsorted list maintainers
    config_test.go:249: The team federation-v2-admins has an unsorted list members
    config_test.go:249: The team kubespray-maintainers has an unsorted list members
    config_test.go:249: The team controller-runtime-maintainers has an unsorted list members
    config_test.go:249: The team kubebuilder-admins has an unsorted list members
    config_test.go:249: The team kubebuilder-contributors has an unsorted list members
    config_test.go:249: The team kube-batch-maintainers has an unsorted list maintainers
    config_test.go:249: The team kube-batch-maintainers has an unsorted list members
    config_test.go:249: The team cluster-api-provider-digitalocean-maintainers has an unsorted list maintainers
    config_test.go:249: The team cri-tools-admins has an unsorted list maintainers
    config_test.go:249: The team kubebuilder-maintainers has an unsorted list members
    config_test.go:249: The team architecture-tracking-admins has an unsorted list maintainers
    config_test.go:249: The team controller-tools-admins has an unsorted list members
    config_test.go:249: The team controller-tools-maintainers has an unsorted list members
    config_test.go:249: The team federation-v2-maintainers has an unsorted list members
    config_test.go:249: The team sig-storage-local-static-provisioner-maintainers has an unsorted list maintainers
    config_test.go:249: The team yaml-maintainers has an unsorted list maintainers
    config_test.go:249: The team architecture-tracking-maintainers has an unsorted list maintainers
    config_test.go:249: The team architecture-tracking-maintainers has an unsorted list members
    config_test.go:249: The team cluster-api-maintainers has an unsorted list members
    config_test.go:249: The team cluster-api-provider-aws-maintainers has an unsorted list members
    config_test.go:249: The team node-feature-discovery-maintainers has an unsorted list members
    config_test.go:249: The team cloud-provider-openstack-maintainers has an unsorted list maintainers
    config_test.go:249: The team sig-multicluster-api-reviews has an unsorted list members
    config_test.go:249: The team sig-architecture-misc-use-only-as-a-last-resort has an unsorted list members
    config_test.go:249: The team sig-azure has an unsorted list maintainers
    config_test.go:249: The team sig-azure has an unsorted list members
    config_test.go:249: The team sig-cli-api-reviews has an unsorted list maintainers
    config_test.go:249: The team sig-cli-api-reviews has an unsorted list members
    config_test.go:249: The team sig-cluster-lifecycle has an unsorted list maintainers
    config_test.go:249: The team sig-cluster-lifecycle has an unsorted list members
    config_test.go:249: The team kubectl-maintainers has an unsorted list maintainers
    config_test.go:249: The team kubectl-maintainers has an unsorted list members
    config_test.go:249: The team sig-scheduling-api-reviews has an unsorted list members
    config_test.go:249: The team kompose-maintainers has an unsorted list maintainers
    config_test.go:249: The team kompose-maintainers has an unsorted list members
    config_test.go:249: The team sig-network-feature-requests has an unsorted list members
    config_test.go:249: The team sig-scalability-api-reviews has an unsorted list maintainers
    config_test.go:249: The team sig-testing-pr-reviews has an unsorted list maintainers
    config_test.go:249: The team cloud-provider-gcp-maintainers has an unsorted list maintainers
    config_test.go:249: The team sig-apps-misc has an unsorted list maintainers
    config_test.go:249: The team sig-apps-misc has an unsorted list members
    config_test.go:249: The team sig-contributor-experience-pr-reviews has an unsorted list maintainers
    config_test.go:249: The team sig-contributor-experience-pr-reviews has an unsorted list members
    config_test.go:249: The team sig-docs-l10n-admins has an unsorted list maintainers
    config_test.go:249: The team sig-docs-l10n-admins has an unsorted list members
    config_test.go:249: The team sig-autoscaling-pr-reviews has an unsorted list members
    config_test.go:249: The team sig-scalability-pr-reviews has an unsorted list maintainers
    config_test.go:249: The team ingress-gce-admins has an unsorted list members
    config_test.go:249: The team kubernetes-anywhere-maintainers has an unsorted list maintainers
    config_test.go:249: The team kubernetes-anywhere-maintainers has an unsorted list members
    config_test.go:249: The team kubernetes-milestone-maintainers has an unsorted list maintainers
    config_test.go:249: The team kubernetes-milestone-maintainers has an unsorted list members
    config_test.go:249: The team sig-apps-proposals has an unsorted list maintainers
    config_test.go:249: The team sig-apps-proposals has an unsorted list members
    config_test.go:249: The team sig-auth-test-failures has an unsorted list members
    config_test.go:249: The team sig-docs-zh-owners has an unsorted list members
    config_test.go:249: The team sig-service-catalog-misc has an unsorted list members
    config_test.go:249: The team dashboard-admins has an unsorted list members
    config_test.go:249: The team intel has an unsorted list members
    config_test.go:249: The team sig-node-bugs has an unsorted list members
    config_test.go:249: The team sig-scheduling-pr-reviews has an unsorted list members
    config_test.go:249: The team autoscaler-reviewers has an unsorted list members
    config_test.go:249: The team sig-node-test-failures has an unsorted list members
    config_test.go:249: The team sig-apps-feature-requests has an unsorted list maintainers
    config_test.go:249: The team sig-apps-feature-requests has an unsorted list members
    config_test.go:249: The team perf-tests-maintainers has an unsorted list members
    config_test.go:249: The team sig-auth-feature-requests has an unsorted list maintainers
    config_test.go:249: The team sig-auth-feature-requests has an unsorted list members
    config_test.go:249: The team sig-contributor-experience-misc-use-only-as-a-last-resort has an unsorted list maintainers
    config_test.go:249: The team sig-contributor-experience-misc-use-only-as-a-last-resort has an unsorted list members
    config_test.go:249: The team sig-docs-ko-owners has an unsorted list members
    config_test.go:249: The team sig-docs-ko-reviews has an unsorted list maintainers
    config_test.go:249: The team sig-instrumentation-proposals has an unsorted list members
    config_test.go:249: The team sig-windows-feature-requests has an unsorted list members
    config_test.go:249: The team cloud-provider-gcp-admins has an unsorted list maintainers
    config_test.go:249: The team code-generator-admins has an unsorted list maintainers
    config_test.go:249: The team dns-admins has an unsorted list members
    config_test.go:249: The team sig-docs-pr-reviews has an unsorted list maintainers
    config_test.go:249: The team sig-docs-pr-reviews has an unsorted list members
    config_test.go:249: The team sig-storage-misc has an unsorted list members
    config_test.go:249: The team cluster-registry-maintainers has an unsorted list maintainers
    config_test.go:249: The team cluster-registry-maintainers has an unsorted list members
    config_test.go:249: The team federation-maintainers has an unsorted list members
    config_test.go:249: The team kompose-admins has an unsorted list members
    config_test.go:249: The team sig-cloud-provider has an unsorted list maintainers
    config_test.go:249: The team sig-cloud-provider has an unsorted list members
    config_test.go:249: The team cloud-provider-sample-admins has an unsorted list maintainers
    config_test.go:249: The team sig-cloud-provider-bugs has an unsorted list maintainers
    config_test.go:249: The team sig-cloud-provider-pr-reviews has an unsorted list maintainers
    config_test.go:249: The team sig-cloud-provider-proposals has an unsorted list maintainers
    config_test.go:249: The team sig-cloud-provider-test-failures has an unsorted list maintainers
    config_test.go:249: The team cloud-provider-sample-maintainers has an unsorted list maintainers
    config_test.go:249: The team sig-cloud-provider-api-reviews has an unsorted list maintainers
    config_test.go:249: The team sig-cloud-provider-feature-requests has an unsorted list maintainers
    config_test.go:249: The team sig-cloud-provider-misc has an unsorted list maintainers
    config_test.go:249: The team sig-multicluster-bugs has an unsorted list maintainers
    config_test.go:249: The team sig-multicluster-bugs has an unsorted list members
    config_test.go:249: The team sig-scheduling-proposals has an unsorted list members
    config_test.go:249: The team cncf-wg has an unsorted list members
    config_test.go:249: The team sig-autoscaling-feature-requests has an unsorted list members
    config_test.go:249: The team sig-autoscaling-proposals has an unsorted list members
    config_test.go:249: The team sig-openstack-misc has an unsorted list members
    config_test.go:249: The team sig-scheduling-bugs has an unsorted list members
    config_test.go:249: The team kubectl-admins has an unsorted list maintainers
    config_test.go:249: The team kubectl-admins has an unsorted list members
    config_test.go:249: The team sig-architecture-proposals has an unsorted list members
    config_test.go:249: The team sig-docs-ja-reviews has an unsorted list maintainers
    config_test.go:249: The team sig-multicluster-misc has an unsorted list maintainers
    config_test.go:249: The team sig-multicluster-misc has an unsorted list members
    config_test.go:249: The team sig-instrumentation-misc has an unsorted list members
    config_test.go:249: The team cloud-provider-vsphere-admins has an unsorted list maintainers
    config_test.go:249: The team kube-deploy-admins has an unsorted list members
    config_test.go:249: The team sig-apps-test-failures has an unsorted list maintainers
    config_test.go:249: The team sig-apps-test-failures has an unsorted list members
    config_test.go:249: The team sig-storage-proposals has an unsorted list members
    config_test.go:249: The team kubernetes-anywhere-admins has an unsorted list maintainers
    config_test.go:249: The team maintainer-test-exemptions has an unsorted list members
    config_test.go:249: The team sig-autoscaling-test-failures has an unsorted list members
    config_test.go:249: The team sig-node-feature-requests has an unsorted list members
    config_test.go:249: The team community-maintainers has an unsorted list members
    config_test.go:249: The team federation-reviewers has an unsorted list members
    config_test.go:249: The team kubernetes-admins has an unsorted list members
    config_test.go:249: The team sig-contributor-experience-bugs has an unsorted list members
    config_test.go:249: The team utils-maintainers has an unsorted list members
    config_test.go:249: The team client-go-maintainers has an unsorted list members
    config_test.go:249: The team sig-cli-misc has an unsorted list maintainers
    config_test.go:249: The team sig-cli-misc has an unsorted list members
    config_test.go:249: The team sig-docs-zh-reviews has an unsorted list maintainers
    config_test.go:249: The team sig-docs-zh-reviews has an unsorted list members
    config_test.go:249: The team sig-testing has an unsorted list maintainers
    config_test.go:249: The team sig-testing has an unsorted list members
    config_test.go:249: The team sig-scheduling-test-failures has an unsorted list members
    config_test.go:249: The team kubernetes-maintainers has an unsorted list maintainers
    config_test.go:249: The team kubernetes-maintainers has an unsorted list members
    config_test.go:249: The team sig-apps-api-reviews has an unsorted list maintainers
    config_test.go:249: The team sig-apps-api-reviews has an unsorted list members
    config_test.go:249: The team sig-auth-bugs has an unsorted list members
    config_test.go:249: The team sig-docs-en-reviews has an unsorted list members
    config_test.go:249: The team sig-multicluster-feature-requests has an unsorted list members
    config_test.go:249: The team client-go-admins has an unsorted list members
    config_test.go:249: The team community-admins has an unsorted list maintainers
    config_test.go:249: The team community-admins has an unsorted list members
    config_test.go:249: The team kubernetes-staging-publish-cops has an unsorted list members
    config_test.go:249: The team sig-auth-misc has an unsorted list maintainers
    config_test.go:249: The team sig-auth-misc has an unsorted list members
    config_test.go:249: The team sig-cli-feature-requests has an unsorted list maintainers
    config_test.go:249: The team sig-cli-feature-requests has an unsorted list members
    config_test.go:249: The team klog-maintainers has an unsorted list members
    config_test.go:249: The team sig-storage-test-failures has an unsorted list members
    config_test.go:249: The team api-reviewers has an unsorted list members
    config_test.go:249: The team kompose-contributors has an unsorted list members
    config_test.go:249: The team sig-cli-maintainers has an unsorted list maintainers
    config_test.go:249: The team sig-cli-maintainers has an unsorted list members
    config_test.go:249: The team sig-multicluster-test-failures has an unsorted list members
    config_test.go:249: The team goog-gke has an unsorted list members
    config_test.go:249: The team sig-node-proposals has an unsorted list members
    config_test.go:249: The team ingress-nginx-maintainers has an unsorted list members
    config_test.go:249: The team kubernetes-blog-maintainers has an unsorted list members
    config_test.go:249: The team sig-instrumentation-api-reviews has an unsorted list members
    config_test.go:249: The team sig-docs-maintainers has an unsorted list maintainers
    config_test.go:249: The team sig-docs-maintainers has an unsorted list members
    config_test.go:249: The team sig-network-api-reviews has an unsorted list members
    config_test.go:249: The team sig-service-catalog-proposals has an unsorted list members
    config_test.go:249: The team code-generator-maintainers has an unsorted list members
    config_test.go:249: The team node-problem-detector-maintainers has an unsorted list members
    config_test.go:249: The team sig-ibmcloud-misc has an unsorted list members
    config_test.go:249: The team sig-contributor-experience-proposals has an unsorted list members
    config_test.go:249: The team k8s.io-maintainers has an unsorted list members
    config_test.go:249: The team metrics-maintainers has an unsorted list members
    config_test.go:249: The team repo-infra-maintainers has an unsorted list members
    config_test.go:249: The team sig-aws-misc has an unsorted list members
    config_test.go:249: The team kube-ui-maintainers has an unsorted list members
    config_test.go:249: The team sig-service-catalog-feature-requests has an unsorted list members
    config_test.go:249: The team sig-storage-feature-requests has an unsorted list members
    config_test.go:249: The team sig-windows-bugs has an unsorted list members
    config_test.go:249: The team sig-auth-api-reviews has an unsorted list members
    config_test.go:249: The team sig-autoscaling-bugs has an unsorted list members
    config_test.go:249: The team sig-windows-misc has an unsorted list members
    config_test.go:249: The team utils-reviewers has an unsorted list members
    config_test.go:249: The team ingress-gce-maintainers has an unsorted list members
    config_test.go:249: The team utils-admins has an unsorted list members
    config_test.go:249: The team cloud-provider-vsphere-maintainers has an unsorted list maintainers
    config_test.go:249: The team product-security-team has an unsorted list members
    config_test.go:249: The team sig-network-pr-reviews has an unsorted list members
    config_test.go:249: The team sig-storage-bugs has an unsorted list members
    config_test.go:249: The team sig-instrumentation-pr-reviews has an unsorted list members
    config_test.go:249: The team sig-auth-pr-reviews has an unsorted list members
    config_test.go:249: The team sig-cli-pr-reviews has an unsorted list maintainers
    config_test.go:249: The team sig-cli-pr-reviews has an unsorted list members
    config_test.go:249: The team contrib-maintainers has an unsorted list members
    config_test.go:249: The team minikube-maintainers has an unsorted list members
    config_test.go:249: The team sig-auth-proposals has an unsorted list members
    config_test.go:249: The team sig-autoscaling-api-reviews has an unsorted list members
    config_test.go:249: The team test-infra-maintainers has an unsorted list maintainers
    config_test.go:249: The team test-infra-maintainers has an unsorted list members
    config_test.go:249: The team metrics-admins has an unsorted list members
    config_test.go:249: The team minikube-admins has an unsorted list members
    config_test.go:249: The team sig-apps-bugs has an unsorted list maintainers
    config_test.go:249: The team sig-apps-bugs has an unsorted list members
    config_test.go:249: The team sig-instrumentation-bugs has an unsorted list members
    config_test.go:249: The team api-approvers has an unsorted list members
    config_test.go:249: The team gengo-reviewers has an unsorted list members
    config_test.go:249: The team sig-scalability-test-failures has an unsorted list maintainers
    config_test.go:249: The team kubeadm-maintainers has an unsorted list members
    config_test.go:249: The team owners has an unsorted list maintainers
    config_test.go:249: The team sig-architecture-api-reviews has an unsorted list members
    config_test.go:249: The team kubectl-reviewers has an unsorted list maintainers
    config_test.go:249: The team kubectl-reviewers has an unsorted list members
    config_test.go:249: The team sig-cli-test-failures has an unsorted list maintainers
    config_test.go:249: The team bots has an unsorted list maintainers
    config_test.go:249: The team bots has an unsorted list members
    config_test.go:249: The team sig-node-pr-reviews has an unsorted list members
    config_test.go:249: The team cluster-registry-admins has an unsorted list maintainers
    config_test.go:249: The team sig-network-proposals has an unsorted list members
    config_test.go:249: The team sig-scalability-misc has an unsorted list maintainers
    config_test.go:249: The team sig-scalability-misc has an unsorted list members
    config_test.go:249: The team sig-instrumentation-feature-requests has an unsorted list members
    config_test.go:249: The team cluster-registry-reviewers has an unsorted list maintainers
    config_test.go:249: The team federation-admins has an unsorted list members
    config_test.go:249: The team sig-api-machinery-misc has an unsorted list members
    config_test.go:249: The team sig-apps-pr-reviews has an unsorted list maintainers
    config_test.go:249: The team sig-apps-pr-reviews has an unsorted list members
    config_test.go:249: The team sig-scalability-proprosals has an unsorted list maintainers
    config_test.go:249: The team sig-scalability-proprosals has an unsorted list members
    config_test.go:249: The team sig-storage-pr-reviews has an unsorted list members
    config_test.go:249: The team cncf-conformance-wg has an unsorted list members
    config_test.go:249: The team node-problem-detector-reviewers has an unsorted list members
    config_test.go:249: The team steering-committee has an unsorted list maintainers
    config_test.go:249: The team steering-committee has an unsorted list members
    config_test.go:249: The team test-infra-admins has an unsorted list maintainers
    config_test.go:249: The team test-infra-admins has an unsorted list members
    config_test.go:249: The team sig-node-api-reviews has an unsorted list members
    config_test.go:249: The team cloud-provider-openstack-admins has an unsorted list maintainers
    config_test.go:249: The team enhancement-maintainers has an unsorted list maintainers
    config_test.go:249: The team features-maintainers has an unsorted list maintainers
    config_test.go:249: The team features-maintainers has an unsorted list members
    config_test.go:249: The team sig-architecture-feature-requests has an unsorted list members
    config_test.go:249: The team sig-autoscaling-misc has an unsorted list members
    config_test.go:249: The team sig-cli-bugs has an unsorted list maintainers
    config_test.go:249: The team sig-cli-bugs has an unsorted list members
    config_test.go:249: The team sig-contributor-experience-feature-requests has an unsorted list maintainers
    config_test.go:249: The team sig-contributor-experience-feature-requests has an unsorted list members
    config_test.go:249: The team sig-docs-en-owners has an unsorted list maintainers
    config_test.go:249: The team sig-docs-en-owners has an unsorted list members
    config_test.go:249: The team sig-mutlicluster-proposals has an unsorted list maintainers
    config_test.go:249: The team sig-mutlicluster-proposals has an unsorted list members
    config_test.go:249: The team sig-network-misc has an unsorted list members
    config_test.go:249: The team kube-deploy-maintainers has an unsorted list members
    config_test.go:249: The team kubeadm-reviewers has an unsorted list maintainers
    config_test.go:249: The team kubeadm-reviewers has an unsorted list members
    config_test.go:249: The team kubernetes-reviewers has an unsorted list maintainers
    config_test.go:249: The team kubernetes-reviewers has an unsorted list members
    config_test.go:249: The team sig-instrumentation-test-failures has an unsorted list members
    config_test.go:249: The team sig-scheduling-feature-requests has an unsorted list members
    config_test.go:249: The team sig-cluster-lifecycle-pr-reviews has an unsorted list maintainers
    config_test.go:249: The team sig-cluster-lifecycle-pr-reviews has an unsorted list members
    config_test.go:249: The team autoscaler-maintainers has an unsorted list members
    config_test.go:249: The team examples has an unsorted list members
    config_test.go:249: The team kubernetes-website-admins has an unsorted list maintainers
    config_test.go:249: The team kubernetes-website-admins has an unsorted list members
    config_test.go:249: The team sig-api-machinery-pr-reviews has an unsorted list members
    config_test.go:249: The team sig-scheduling-misc has an unsorted list members
    config_test.go:249: The team ubuntu-image has an unsorted list members
    config_test.go:249: The team sig-multicluster-pr-reviews has an unsorted list members
    config_test.go:249: The team sig-scalability-bugs has an unsorted list maintainers
    config_test.go:249: The team goog-image has an unsorted list members
    config_test.go:249: The team ingress-gce-reviewers has an unsorted list members
    config_test.go:249: The team kops-maintainers has an unsorted list members
    config_test.go:249: The team kubeadm-admins has an unsorted list members
    config_test.go:249: The team sig-architecture-pr-reviews has an unsorted list members
    config_test.go:249: The team sig-cloud-provider-admins has an unsorted list maintainers
    config_test.go:249: The team k8s-infra-team has an unsorted list maintainers
    config_test.go:249: The team k8s-infra-team has an unsorted list members
    config_test.go:249: The team sig-cli-proposals has an unsorted list maintainers
    config_test.go:249: The team sig-cli-proposals has an unsorted list members
    config_test.go:249: The team sig-docs-ja-owners has an unsorted list members
    config_test.go:249: The team sig-storage-api-reviews has an unsorted list members
    config_test.go:249: The team dashboard-maintainers has an unsorted list members
    config_test.go:249: The team sig-scalability-feature-requests has an unsorted list maintainers
    config_test.go:249: The team sig-scalability-feature-requests has an unsorted list members
    config_test.go:249: The team Reviewers has an unsorted list members
FAIL

@fejta
Copy link
Contributor

fejta commented Jan 16, 2019

How did this pass unit tests?
/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2019
@cblecker
Copy link
Member

/hold cancel

The function was basically sorting whatever it got, before checking if it was sorted lol

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 68f28a7 into kubernetes:master Jan 17, 2019
@nikhita nikhita deleted the fix-sort-function branch January 17, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta Awaiting requested review from fejta

@grodrigues3 grodrigues3 Awaiting requested review from grodrigues3

Assignees

@fejta fejta

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikhita @fejta @k8s-ci-robot @cblecker