Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seanmalloy and ingvagabund to descheduler repo with write access #3433

Merged

Conversation

seanmalloy
Copy link
Member

There is currently only one active maintainer with write access to the
descheduler repo. Adding a second maintainer with write access allows
multiple people to help with create git tags and branches for releases.

There is currently only one active maintainer with write access to the
descheduler repo. Adding a second maintainer with write access allow
multiple people to help with create git tags and branchs for releases.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2022
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels May 20, 2022
@seanmalloy
Copy link
Member Author

@damemi and @ingvagabund let me know if you have any concerns with this change.

/cc @damemi @ingvagabund

Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
would also like to nominate @ingvagabund

There is currently only one active maintainer with write access to the
descheduler repo. Adding a second maintainer with write access allow
multiple people to help with create git tags and branchs for releases.
@seanmalloy
Copy link
Member Author

would also like to nominate @ingvagabund

I pushed a second commit that adds @ingvagabund with write access.

@seanmalloy
Copy link
Member Author

/assign @ahg-g

@seanmalloy seanmalloy changed the title Add seanmalloy to descheduler repo with write access Add seanmalloy and ingvagabund to descheduler repo with write access May 20, 2022
@damemi
Copy link
Contributor

damemi commented May 20, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2022
@seanmalloy
Copy link
Member Author

@ahg-g and @Huang-Wei please take a look when you have some time.

/assign @Huang-Wei

@Huang-Wei
Copy link
Member

/approve

(but not sure ^^ works 😅)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, Huang-Wei, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit f412a0c into kubernetes:main Jun 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 10, 2022
@seanmalloy seanmalloy deleted the update-descheduler-maintainers branch June 13, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants