Enable team management for peribolos

[cblecker]

🙊!

This might actually work.
fixes #336

/assign @fejta @spiffxp
/hold

[nikhita]

@cblecker 🎉 🎈

Two questions:

• Can we move the teams to a teams.yaml and merge the configs to avoid bloating org.yaml, like we do for contribex? Or do we intend to move to a teams.yaml for each SIG later?

• Out of curiosity, how do --dump, --fix-teams and --fix-team-members come to know that sig-contribex teams should be dumped in its teams.yaml file and not append those in org.yaml? 🤔

[cblecker]

@nikhita Thanks for feedback!

Can we move the teams to a teams.yaml and merge the configs to avoid bloating org.yaml, like we do for contribex?

Yes, we can.. it just requires manually trimming out the groups into a new folder, like contribex and apimachinery. I haven't done that yet, because it's a manual process, and I'm currently trying to keep the dump sync'd with what's in GitHub.

Out of curiosity, how do --dump, --fix-teams and --fix-team-members come to know that sig-contribex teams should be dumped in its teams.yaml file and not append those in org.yaml?

Manually :) I dumped out the list of teams, and then extracted out contribex and apimachinery as examples. I want to get peribolos as the source of truth first, and then we can do it for all the sigs to delegate approve rights.

[fejta]

Manually :) I dumped out the list of teams, and then extracted out contribex and apimachinery as examples.

However we organize the files https://github.com/kubernetes/org/tree/master/cmd/merge will then stitch them back together into one config.

[nikhita]

Manual sounds like a lot of work though 😛 ....if teams have consistent naming, maybe we could automate it? But I think we should discuss this later on an issue somewhere and not on this PR. Thanks for getting this ready, again! 💯

[fejta]

/lgtm
Any chance we want to leave out the third commit that enables --fix-teams and put that in a separate PR?

[fejta]

LOL

[fejta]

why am I a bot?! 😁

[cblecker]

@fejta The reason I'm just turning it all on now is we would need a last "sync" from GitHub before we turn it on anyways. I figure I'll do that Friday morning right before merge.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cblecker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fejta]

/lgtm
/hold
exciting! I guess Friday afternoon is the natural time to make this switch?

[cblecker]

/hold cancel
Let's do this! 🚀