Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jichenjc into owner of cloud-provider-openstack #3368

Merged
merged 1 commit into from
May 10, 2022
Merged

Add jichenjc into owner of cloud-provider-openstack #3368

merged 1 commit into from
May 10, 2022

Conversation

jichenjc
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject area/provider/openstack Issues or PRs related to openstack provider labels Apr 12, 2022
@k8s-ci-robot k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Apr 12, 2022
@lingxiankong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2022
@mrbobbytables
Copy link
Member

/assign @cheftako @andrewsykim @nckturner
For sign off of team + owners_aliases change

@jichenjc
Copy link
Contributor Author

it has been 2 weeks for this PR , can anyone help on approve ? Thanks

@jichenjc
Copy link
Contributor Author

jichenjc commented May 9, 2022

@cheftako @andrewsykim @nckturner

can you help to approve this request? THanks

@nckturner
Copy link
Contributor

/approve

@jichenjc
Copy link
Contributor Author

/assign @ameukam

@ameukam
Copy link
Member

ameukam commented May 10, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, jichenjc, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit acc0b3e into kubernetes:main May 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palnabarun palnabarun Awaiting requested review from palnabarun

@ramineni ramineni Awaiting requested review from ramineni

Assignees

@cheftako cheftako

@nckturner nckturner

@ameukam ameukam

@lingxiankong lingxiankong

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
8 participants
@jichenjc @lingxiankong @mrbobbytables @nckturner @ameukam @k8s-ci-robot @cheftako @andrewsykim