Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add members 2018-12-24 #325

Merged
merged 1 commit into from
Dec 24, 2018
Merged

Add members 2018-12-24 #325

merged 1 commit into from
Dec 24, 2018

Conversation

mrbobbytables
Copy link
Member

fixes #323

/area github-membership

@k8s-ci-robot k8s-ci-robot added the area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team label Dec 24, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 24, 2018
@mrbobbytables mrbobbytables mentioned this pull request Dec 24, 2018
Closed
cblecker
cblecker approved these changes Dec 24, 2018
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit 83561a5 into kubernetes:master Dec 24, 2018
@mrbobbytables mrbobbytables deleted the add-members-2018-12-24 branch January 3, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker approved these changes

@idvoretskyi idvoretskyi Awaiting requested review from idvoretskyi

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REQUEST: New membership for @yagonobre on @kubernetes-sigs
3 participants
@mrbobbytables @k8s-ci-robot @cblecker