Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sig-docs-bn members #3235

Closed
wants to merge 5 commits into from
Closed

Add sig-docs-bn members #3235

wants to merge 5 commits into from

Conversation

mitul3737
Copy link
Member

Adding sig docs Bengali Localization owners and reviewers.

Adding sig docs Bengali localization owners and reviewers
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 6, 2022

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @mitul3737!

It looks like this is your first PR to kubernetes/org 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/org has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 6, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mitul3737. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 6, 2022
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 6, 2022
@cblecker
Copy link
Member

cblecker commented Feb 7, 2022

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 7, 2022
@Imtiaz1234
Copy link
Member

/assign @divya-mohan0209

@mrbobbytables
Copy link
Member

/easycla

config/kubernetes/sig-docs/teams.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mitul3737
To complete the pull request process, please ask for approval from divya-mohan0209 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@palnabarun
Copy link
Member

/easycla

@divya-mohan0209
Copy link
Contributor

divya-mohan0209 commented Feb 7, 2022

@mitul3737 : Please sign the CLA :) Make sure to add it in your variables when pushing the commit, as well.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 7, 2022
@mitul3737
Copy link
Member Author

mitul3737 commented Feb 7, 2022

@divya-mohan0209 is it done now? Can you please check?

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the existing format, could we please have this ordered alphabetically? To clarify, please move this before sig-docs-de-owners.

@mitul3737
Copy link
Member Author

@divya-mohan0209 can you have a look, please? 😊

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit detected in phrasing

config/kubernetes/sig-docs/teams.yaml Outdated Show resolved Hide resolved
@mitul3737
Copy link
Member Author

@divya-mohan0209 Done 😊

@divya-mohan0209
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@mitul3737
Copy link
Member Author

@divya-mohan0209 anything I need to do now? As the test failed?

@mitul3737
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@mitul3737: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@divya-mohan0209
Copy link
Contributor

None of you are Kubernetes org members, that's why it has failed. You will have to request for org membership with the help of two sponsors.

@divya-mohan0209
Copy link
Contributor

/remove-lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@mitul3737
Copy link
Member Author

@divya-mohan0209 yes, I am not an org member but I am adding these to contribute to the Bengali documentation page. What will be the next step? What do you mean by the sponsor?

@palnabarun
Copy link
Member

@mitul3737 -- you need to be an org member to be added as an owner/approver/reviewer to any part of the codebase. As @divya-mohan0209 said, you need to request a membership first. Also, in order to contribute to the Bengali documentation page, you don't need to be an owner/approver.

Please read the guidelines here. They will answer your questions.

@mitul3737
Copy link
Member Author

@palnabarun sure!

@divya-mohan0209
Copy link
Contributor

@mitul3737 : Would also request that you/one of the representatives mentioned above join the localization meeting today. This would help further clarify any doubts you have surrounding starting up a localization.

@sftim
Copy link
Contributor

sftim commented Feb 8, 2022

/ok-to-test

(will fail, at the moment)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2022
@k8s-ci-robot
Copy link
Contributor

@mitul3737: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-org-test-all 8befce9 link true /test pull-org-test-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mitul3737 mitul3737 closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants