Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Init kubernetes-nightly org #3131

Merged
merged 6 commits into from
Dec 8, 2021
Merged

config: Init kubernetes-nightly org #3131

merged 6 commits into from
Dec 8, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Dec 6, 2021 •
edited
Loading

Part of kubernetes/sig-release#1772.

  • config: Init kubernetes-nightly org
  • k-nightly: Add NMCs as members
  • k-nightly: Add SIG Release teams
  • k-nightly: Add Release Engineering as org members
  • k-nightly: Promote publishing-bot-admins to org admins
  • k-nightly: Update config to reflect existing org membership

Signed-off-by: Stephen Augustus foo@auggie.dev

Slack convo: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1638832884428700

@justaugustus
config: Init kubernetes-nightly org
405fd93 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2021
@justaugustus
k-nightly: Add NMCs as members
93625aa 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
k-nightly: Add SIG Release teams
e4d8f72 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
k-nightly: Add Release Engineering as org members
b7b13b5 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
k-nightly: Promote publishing-bot-admins to org admins
d3f2cbd 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus justaugustus changed the title [WIP] config: Init kubernetes-nightly org config: Init kubernetes-nightly org Dec 7, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2021
@justaugustus
Copy link
Member Author

/hold until k8s-github-robot is an org owner for https://github.com/kubernetes-nightly

From @cblecker on Slack:

I just reviewed the code path quickly, and as long as k8s-github-robot is an owner, it should be able to do the rest

/assign @cblecker @mrbobbytables
cc: @kubernetes/publishing-bot-maintainers @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2021
@justaugustus justaugustus mentioned this pull request Dec 7, 2021
Merged
@justaugustus
Copy link
Member Author

Docs update: kubernetes/community#6271

@sttts
Copy link

sttts commented Dec 7, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2021
@justaugustus justaugustus mentioned this pull request Dec 7, 2021
Closed
10 tasks
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2021
@justaugustus justaugustus force-pushed the nightly-org branch 3 times, most recently from 727391d to 8203dba Compare December 8, 2021 05:09
@justaugustus
Copy link
Member Author

/hold cancel
This should be good to go now that @k8s-ci-robot has been added as a org admin for kubernetes-nightly org (ref, thanks @cjwagner!)

FYI @kubernetes/owners @kubernetes/publishing-bot-maintainers @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2021
@puerco
Copy link
Member

puerco commented Dec 8, 2021

From @kubernetes/release-engineering
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2021
@cblecker
Copy link
Member

cblecker commented Dec 8, 2021

/hold

I'll take a look at this tomorrow. Want to watch that peribolos run closely when we bootstrap a new org.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2021
cblecker
cblecker reviewed Dec 8, 2021
View reviewed changes
config/kubernetes-nightly/org.yaml
has_repository_projects: true
members_can_create_repositories: false
billing_email: github@kubernetes.io
admins:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question @justaugustus -- if there are teams that have access to the repos, do we need to have all the release managers as org admins here too? Wondering if there is a technical reason :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question @justaugustus -- if there are teams that have access to the repos, do we need to have all the release managers as org admins here too? Wondering if there is a technical reason :)

Currently, only members of the @kubernetes/owners + @kubernetes/publishing-bot-admins (pub-bot approvers + @kubernetes/sig-release-admins) are listed as org admins.

Our default repo creation permission is:

members_can_create_repositories: false

Given the kubernetes-nightly org exists to test the creation of repos, some subset of SIG Release needs access to do so.

As we learn more (and get the process documented), we can probably start to:

  • automate more (bot account + GCB job (or something))
  • revisit org admins

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great! Thanks @justaugustus !

@justaugustus
k-nightly: Update config to reflect existing org membership
63affa6 
- Add k8s-publishing-bot (member)

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2021
@cblecker
Copy link
Member

cblecker commented Dec 8, 2021

/lgtm
/approve
/hold cancel

:shipit:

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit d92fb3e into kubernetes:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker left review comments

@idvoretskyi idvoretskyi Awaiting requested review from idvoretskyi

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@sttts sttts

@cblecker cblecker

@puerco puerco

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @sttts @puerco @cblecker @k8s-ci-robot @mrbobbytables