Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add jlbutler to docs website-maintainers for 1.23 release #3125

Merged
merged 1 commit into from
Dec 6, 2021
Merged

add jlbutler to docs website-maintainers for 1.23 release #3125

merged 1 commit into from
Dec 6, 2021

Conversation

jlbutler
Copy link
Contributor

@jlbutler jlbutler commented Dec 3, 2021

Adding myself to Docs website-maintainers temporarily to work on the 1.23 release.

/assign @jimangel @divya-mohan0209

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2021
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 3, 2021
@jlbutler
Copy link
Contributor Author

jlbutler commented Dec 3, 2021

/hold until Monday Dec 6th 2021 (a day before 1.23 release)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2021
@jimangel
Copy link
Member

jimangel commented Dec 5, 2021

Making the /hold load bearing 😄

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel, jlbutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2021
@jlbutler
Copy link
Contributor Author

jlbutler commented Dec 6, 2021

It's the day before the release, dropping his hold.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 80eda84 into kubernetes:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees

@jimangel jimangel

@divya-mohan0209 divya-mohan0209

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlbutler @jimangel @k8s-ci-robot @divya-mohan0209