Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add issue templates #3

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Add issue templates #3

merged 1 commit into from
Aug 8, 2018

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Aug 7, 2018

This adds issue templates to allow users to submit common kinds of requests.

@cblecker
Copy link
Member Author

cblecker commented Aug 7, 2018

/cc @kubernetes/owners

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 7, 2018
@k8s-ci-robot k8s-ci-robot requested review from a team, fejta and philips August 7, 2018 23:25
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2018
spiffxp
spiffxp reviewed Aug 7, 2018
View reviewed changes
.github/ISSUE_TEMPLATE/repo-create.md Outdated
e.g (at)example_user should have write access

### Has sig-architecture reviewed/approved this request?
e.g. Yes, and here's the link.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For kubernetes-sigs, sig-arch doesn't have a say, it's just the owning sig.

I am preferential to linkable proof in the form of a mailing list thread or meeting minutes. I'm not going to accept a slack link. Really don't know how I feel about a youtube link either.

spiffxp
spiffxp reviewed Aug 7, 2018
View reviewed changes
.github/ISSUE_TEMPLATE/integrations.md Outdated
@@ -0,0 +1,20 @@
---
name: Integrations or Webhooks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Maybe include GitHub Apps in the wording somewhere in here too

@spiffxp
Copy link
Member

spiffxp commented Aug 7, 2018

/hold
These are awesome. My main reservation is on the repo-create form. The rules are different depending on which org you want to create in. I don't know if we have to go so far as to state which repos people can choose from (ie: disallow creating in kubernetes-incubator).

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2018
@cblecker
Copy link
Member Author

cblecker commented Aug 7, 2018

@spiffxp Addressed comments. PTAL

@spiffxp
Copy link
Member

spiffxp commented Aug 8, 2018

/approve
I'll leave it to someone else to /lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2018
idvoretskyi
idvoretskyi approved these changes Aug 8, 2018
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2018
@cblecker
Copy link
Member Author

cblecker commented Aug 8, 2018

/hold cancel

If there are other comments, open to iterating.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 2fb128b into kubernetes:master Aug 8, 2018
@cblecker cblecker deleted the issue-template branch August 8, 2018 17:49
k8s-ci-robot pushed a commit that referenced this pull request May 13, 2022
@hpopal11
Revert "updated to add contributor comms team" (#3)
860a842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp left review comments

@idvoretskyi idvoretskyi idvoretskyi approved these changes

Assignees

@idvoretskyi idvoretskyi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cblecker @spiffxp @k8s-ci-robot @idvoretskyi