Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Members 04-27-2021 #2664

Merged
merged 7 commits into from
Apr 28, 2021
Merged

Add Members 04-27-2021 #2664

merged 7 commits into from
Apr 28, 2021

Conversation

savitharaghunathan
Copy link
Member

@savitharaghunathan savitharaghunathan commented Apr 28, 2021 •
edited
Loading

Fixes #2663
Fixes #2662
Fixes #2661
Fixes #2660
Fixes #2659
Fixes #2658
Fixes #2652

/cc @ameukam @palnabarun

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2021
This was referenced Apr 28, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@savitharaghunathan
Copy link
Member Author

/hold for reviews

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2021
nikhita
nikhita approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @savitharaghunathan! 😄

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, savitharaghunathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita
Copy link
Member

nikhita commented Apr 28, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 12d2794 into kubernetes:main Apr 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 28, 2021
@binacs binacs mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@nikhita nikhita nikhita approved these changes

@ameukam ameukam Awaiting requested review from ameukam

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
4 participants
@savitharaghunathan @k8s-ci-robot @nikhita @SergeyKanzhelev