Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update sig-docs-es member list #2522

Conversation

raelga
Copy link
Member

@raelga raelga commented Feb 24, 2021

@alexbrand is stepping down from the sig-docs team as owner. This PRs removes him from the owner and maintainer teams, will remain part of the team sig-docs-es reviewer.

@electrocucaracha will be the new owner for the sig-docs-es team.

/cc @alexbrand

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2021
@raelga
Copy link
Member Author

raelga commented Feb 25, 2021

/assign @sftim

@raelga
Copy link
Member Author

raelga commented Feb 27, 2021

/assign @kbarnard10

@raelga
Copy link
Member Author

raelga commented Mar 1, 2021

/assign @kbhawkey
(This week PR wrangler)

@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 1, 2021

/lgtm
@raelga , Are you required to have 2 owners or can this PR move forward as is?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2021
@raelga
Copy link
Member Author

raelga commented Mar 1, 2021

@kbhawkey I think we can move forward, I will open a new PR with the new member this week!

Thanks :)

@raelga
Copy link
Member Author

raelga commented Mar 8, 2021

@kbarnard10 let me know if there anything else that I need to add to this PR. :)

@sftim
Copy link
Contributor

sftim commented Mar 8, 2021

@raelga is there anyone who can vouch for this PR? Perhaps @alexbrand - or another contributor to the Spanish localization?

@sftim

This comment has been minimized.

@raelga
Copy link
Member Author

raelga commented Mar 9, 2021

I spoke with @alexbrand some time ago and agreed on stepping down from the role. The clean up is just to avoid PRs getting assigned to him.

On today's weekly meeting we will discuss the new approver for the Spanish team to replace @alexbrand and we will create a PR with the updated list.

Anyhow, @electrocucaracha can probably vouch this PR.

@raelga
Copy link
Member Author

raelga commented Mar 9, 2021

@sftim @electrocucaracha will be the new approver for the Spanish team. We will create a PR for that request once this one is merged.

@raelga
Copy link
Member Author

raelga commented Mar 11, 2021

@sftim @kbarnard10 Let me know if you need anything else to get this PR merged, so we can open a new PR for the new approver without having merge conflicts.

@raelga raelga force-pushed the clean/remove-alexbrand-from-sig-docs-es-owners branch from 833784f to 06a0fe7 Compare March 11, 2021 23:05
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021
@raelga
Copy link
Member Author

raelga commented Mar 11, 2021

@sftim @kbarnard10 To avoid the second PR, I'm including the new approver for the sig-docs-es team (@electrocucaracha) in this PR.

/retitle feat: update sig-docs-es member list
/auto-cc

@k8s-ci-robot k8s-ci-robot changed the title feat: remove alexbrand from sig-docs-es owners feat: update sig-docs-es member list Mar 11, 2021
@raelga raelga force-pushed the clean/remove-alexbrand-from-sig-docs-es-owners branch from 06a0fe7 to 1221c6d Compare March 11, 2021 23:09
@raelga raelga force-pushed the clean/remove-alexbrand-from-sig-docs-es-owners branch from 1221c6d to e4c0123 Compare March 11, 2021 23:55
@kbhawkey
Copy link
Contributor

The changes look okay.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2021
@electrocucaracha
Copy link
Contributor

electrocucaracha commented Mar 15, 2021

/lgtm
/approve

@raelga
Copy link
Member Author

raelga commented Mar 15, 2021

Ready to merge @kbhawkey :)

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, kbhawkey, raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3a9b3e4 into kubernetes:main Mar 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 16, 2021
raelga added a commit to raelga/kubernetes-website that referenced this pull request Apr 6, 2021
Updates OWNERs file to match `kubernets/org` file updated at kubernetes/org#2522.
xing-yang pushed a commit to xing-yang/website that referenced this pull request Apr 11, 2021
Updates OWNERs file to match `kubernets/org` file updated at kubernetes/org#2522.
gyunnkim pushed a commit to gyunnkim/website that referenced this pull request Apr 18, 2021
Updates OWNERs file to match `kubernets/org` file updated at kubernetes/org#2522.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants