Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SIG Release teams for 1.21 Release #2405

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Update SIG Release teams for 1.21 Release #2405

merged 1 commit into from
Jan 13, 2021

Conversation

palnabarun
Copy link
Member

@palnabarun palnabarun commented Jan 8, 2021 •
edited
Loading

  • Add RT Lead, EA, RT Lead shadows and Role Leads to
    • milestone-maintainers
    • release-team
  • Add RT Lead, EA, RT Lead Shadows to release-team-leads
  • Add CI Signal Lead to ci-signal

ref: kubernetes/sig-release#1404

/assign
/sig release
/area release-team
/priority critical-urgent
/assign @justaugustus @saschagrunert @jeremyrickard @hasheddan @alejandrox1
/cc @kikisdeliveryservice @savitharaghunathan @bai

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jan 8, 2021
@k8s-ci-robot
Copy link
Contributor

@palnabarun: The label(s) area/release-team cannot be applied, because the repository doesn't have them

In response to this:

  • Add RT Lead, EA, RT Lead shadows and Role Leads to
  • milestone-maintainers
  • release-team
  • Add RT Lead, EA, RT Lead Shadows to release-team-leads
  • Add CI Signal Lead to ci-signal
  • Prune 1.20 RT members (Thank you all for your service ❤️ )

/assign
/sig release
/area release-team
/priority critical-urgent
/assign @justaugustus @saschagrunert @jeremyrickard @hasheddan @alejandrox1
/cc @kikisdeliveryservice @savitharaghunathan @bai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jan 8, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 8, 2021
@palnabarun palnabarun mentioned this pull request Jan 8, 2021
Closed
21 tasks
savitharaghunathan
savitharaghunathan reviewed Jan 8, 2021
View reviewed changes
config/kubernetes/sig-release/teams.yaml Outdated
- palnabarun # 1.20 RT Lead Shadow
- savitharaghunathan # 1.20 RT Lead Shadow
- bai # 1.21 RT Lead Shadow
- oikiki # 1.21 Emeritus Adviser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nabarun, Can you replace 1.21 Emeritus Adviser with 1.21 RT Lead Shadow?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think Kirsten's GH id is @kikisdeliveryservice

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 3AM commits are harmful. xD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a promotion!! Thank you for your confidence!!!! 😉

jeremyrickard
jeremyrickard reviewed Jan 8, 2021
View reviewed changes
config/kubernetes/sig-release/teams.yaml
- palnabarun # 1.20 RT Lead Shadow
- savitharaghunathan # 1.20 RT Lead Shadow
- bai # 1.21 RT Lead Shadow
- kikisdeliveryservice # 1.21 RT Lead Shadow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol you refreshed before i could comment :) :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3AM commits are harmful. xD

hasheddan
hasheddan approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold if folks want to verify their comments were addressed

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 8, 2021
justaugustus
justaugustus suggested changes Jan 8, 2021
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

I might suggest making this PR strictly additive, unless you're positive the contributor in question:

  1. Is definitely not returning to the Release Team
  2. Will not hold another role that grants them milestone maintainer privileges

With 1, you may have shadows returning and you'll end up having to add them back.
I'd wait until the entire team is locked in to do deletions.

config/kubernetes/sig-release/teams.yaml Outdated Show resolved Hide resolved
@palnabarun
update SIG Release teams for 1.21 Release
0576d3c 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2021
@palnabarun
Copy link
Member Author

palnabarun commented Jan 11, 2021 •
edited
Loading

@justaugustus -- the suggestion makes sense. I've made this changeset strictly additive.

@justaugustus
Copy link
Member

Here we go!

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 453457e into kubernetes:master Jan 13, 2021
@palnabarun palnabarun deleted the 1.21-update-teams branch January 13, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitharaghunathan savitharaghunathan savitharaghunathan left review comments

@jeremyrickard jeremyrickard jeremyrickard left review comments

@justaugustus justaugustus justaugustus requested changes

@hasheddan hasheddan hasheddan approved these changes

@bai bai Awaiting requested review from bai

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

@alejandrox1 alejandrox1

@palnabarun palnabarun

@hasheddan hasheddan

@jeremyrickard jeremyrickard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@palnabarun @k8s-ci-robot @justaugustus @savitharaghunathan @kikisdeliveryservice @hasheddan @jeremyrickard @saschagrunert @alejandrox1