Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Donny Xia (@Shell32-Natsu) to kustomize maintainers. #2161

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Add Donny Xia (@Shell32-Natsu) to kustomize maintainers. #2161

merged 1 commit into from
Oct 15, 2020

Conversation

Shell32-Natsu
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject labels Sep 1, 2020
@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Sep 1, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 1, 2020
@Shell32-Natsu
Copy link
Contributor Author

/cc @monopole

@Shell32-Natsu
Copy link
Contributor Author

/retest

@monopole
Copy link
Contributor

monopole commented Sep 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2020
@mrbobbytables
Copy link
Member

/assign @pwittrock @soltysh
for approval

nikhita
nikhita approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been open for a while. Going to go ahead and approve since both Donny and Jeff are approvers for kustomize.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, Shell32-Natsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0e06c48 into kubernetes:master Oct 15, 2020
@Shell32-Natsu Shell32-Natsu deleted the add-donny-xia branch October 15, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

@pwittrock pwittrock Awaiting requested review from pwittrock

@soltysh soltysh Awaiting requested review from soltysh

@monopole monopole Awaiting requested review from monopole

Assignees

@soltysh soltysh

@monopole monopole

@pwittrock pwittrock

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Shell32-Natsu @monopole @mrbobbytables @k8s-ci-robot @nikhita @soltysh @pwittrock