-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add member 2020-08-24 #2129
Merged
k8s-ci-robot
merged 2 commits into
kubernetes:master
from
palnabarun:2020-08-24-add-members
Aug 25, 2020
Merged
Add member 2020-08-24 #2129
k8s-ci-robot
merged 2 commits into
kubernetes:master
from
palnabarun:2020-08-24-add-members
Aug 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
k8s-ci-robot
added
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
area/github-management
Issues or PRs related to GitHub Management subproject
labels
Aug 24, 2020
k8s-ci-robot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Aug 24, 2020
6 tasks
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
6 tasks
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Aug 25, 2020
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Aug 25, 2020
/approve Thank you!! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhita, palnabarun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/github-management
Issues or PRs related to GitHub Management subproject
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2128
fixes #2130
/hold
(holding for closing more requests in a batch)