Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fale to IT approver #2100

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Add fale to IT approver #2100

merged 1 commit into from
Aug 12, 2020

Conversation

fabriziopandini
Copy link
Member

As per slack discussion https://kubernetes.slack.com/archives/CGB1MCK7X/p1597166062151500, adding @Fale as approver for the IT localization of the website

xref kubernetes/website#23098

/area github-membership
/assing @rlenferink
/cc @Fale

@k8s-ci-robot k8s-ci-robot requested a review from Fale August 12, 2020 09:11
@k8s-ci-robot k8s-ci-robot added area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 12, 2020
@fabriziopandini fabriziopandini mentioned this pull request Aug 12, 2020
Merged
@fabriziopandini
Copy link
Member Author

/assign @rlenferink

@Fale
Copy link
Member

Fale commented Aug 12, 2020

Thanks a lot :-)
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2020
rlenferink
rlenferink approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@rlenferink rlenferink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for your contributions so far @Fale 🎉

/assign @zacharysarah
for approval

@zacharysarah
Copy link

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, Fale, rlenferink, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 91fd0d8 into kubernetes:master Aug 12, 2020
@fabriziopandini fabriziopandini deleted the add-fale-to-IT-approvers branch August 13, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlenferink rlenferink rlenferink approved these changes

@Fale Fale Fale approved these changes

Assignees

@Fale Fale

@zacharysarah zacharysarah

@rlenferink rlenferink

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fabriziopandini @Fale @zacharysarah @k8s-ci-robot @rlenferink