Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create GitHub team for minibroker repo #2021

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Create GitHub team for minibroker repo #2021

merged 1 commit into from
Jul 15, 2020

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jul 14, 2020

Fixes #2019

/assign @carolynvs

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 14, 2020
@nikhita nikhita mentioned this pull request Jul 14, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 14, 2020
@carolynvs
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit aae80b0 into kubernetes:master Jul 15, 2020
@carolynvs
Copy link

Thanks for the help, 1.0 here we come! 🚀

@nikhita nikhita deleted the minibroker-teams branch July 15, 2020 13:06
@nikhita
Copy link
Member Author

nikhita commented Jul 15, 2020

The minibroker-admins team has been granted admin access. With that, I've removed admin access from https://github.com/orgs/kubernetes-sigs/teams/service-catalog-admins and write access from https://github.com/orgs/kubernetes-sigs/teams/service-catalog-maintainers. Please let me know if they need to have access again and I'll add them back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberkhahn jberkhahn Awaiting requested review from jberkhahn

@mszostok mszostok Awaiting requested review from mszostok

Assignees

@carolynvs carolynvs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add carolynvs as adminstrator to kubernetes-sigs/minibroker
3 participants
@nikhita @k8s-ci-robot @carolynvs