Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add teams for cloud-provider-baiducloud repo #1745

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Add teams for cloud-provider-baiducloud repo #1745

merged 1 commit into from
Mar 25, 2020

Conversation

mrbobbytables
Copy link
Member

ref: #1716

/area github-repo

@k8s-ci-robot k8s-ci-robot added area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2020
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 25, 2020
@mrbobbytables mrbobbytables mentioned this pull request Mar 25, 2020
Closed
nikhita
nikhita approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2f090c6 into kubernetes:master Mar 25, 2020
@mrbobbytables mrbobbytables deleted the add-baiducloud-teams branch May 16, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrbobbytables @k8s-ci-robot @nikhita